Add Shlcofideleg support #1847
Open
Add Shlcofideleg support #1847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aswaterman
reviewed
Oct 31, 2024
riscv/csrs.cc
Outdated
| reg_t generic_int_accessor_t::ip_read() const noexcept { | ||
| return (state->mip->read() & deleg_mask() & read_mask) >> shiftamt; | ||
| const reg_t val = state->mip->read() & deleg_mask() & read_mask; | ||
| return ((val & 0xfff) >> shiftamt) | (val & ~0xfff); |
There was a problem hiding this comment.
The magic constant 0xfff is not OK. Same comment applies throughout the rest of this file.
There was a problem hiding this comment.
magic number removed in new commit
Signed-off-by: demin.han <[email protected]>
demin-han
force-pushed
the
Shlcofideleg-support
branch
from
608207c to
e86b256
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.