Skip to content

CI(riscv64): switch debootstrap root to Debian trixie to restore musl availability #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

CI(riscv64): switch debootstrap root to Debian trixie to restore musl availability #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 47 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,18 @@ jobs:
v8_enable_pointer_compression: false
cargo: cargo

- os: ${{ github.repository == 'denoland/rusty_v8' && 'ubuntu-22.04-xl' || 'ubuntu-22.04' }}
target: riscv64gc-unknown-linux-gnu
variant: debug
v8_enable_pointer_compression: false
cargo: cargo

- os: ${{ github.repository == 'denoland/rusty_v8' && 'ubuntu-22.04-xl' || 'ubuntu-22.04' }}
target: riscv64gc-unknown-linux-gnu
variant: release
v8_enable_pointer_compression: false
cargo: cargo

# simdutf builds
- os: macos-15-large
target: x86_64-apple-darwin
Expand Down Expand Up @@ -174,6 +186,20 @@ jobs:
simdutf: true
cargo: cargo

- os: ${{ github.repository == 'denoland/rusty_v8' && 'ubuntu-22.04-xl' || 'ubuntu-22.04' }}
target: riscv64gc-unknown-linux-gnu
variant: debug
v8_enable_pointer_compression: false
simdutf: true
cargo: cargo

- os: ${{ github.repository == 'denoland/rusty_v8' && 'ubuntu-22.04-xl' || 'ubuntu-22.04' }}
target: riscv64gc-unknown-linux-gnu
variant: release
v8_enable_pointer_compression: false
simdutf: true
cargo: cargo

- os: ${{ github.repository == 'denoland/rusty_v8' && 'windows-2022-xxl' || 'windows-2022' }}
target: x86_64-pc-windows-msvc
variant: release # Note: we do not support windows debug builds.
Expand Down Expand Up @@ -217,7 +243,7 @@ jobs:
python-version: 3.11.x
architecture: x64

- name: Install cross compilation toolchain
- name: Install cross compilation toolchain (aarch64)
if: matrix.config.target == 'aarch64-unknown-linux-gnu'
run: |
rustup target add aarch64-unknown-linux-gnu
Expand All @@ -228,12 +254,29 @@ jobs:
gcc-10-aarch64-linux-gnu libc6-arm64-cross qemu qemu-user \
qemu-user-binfmt

sudo ln -s /usr/aarch64-linux-gnu/lib/ld-linux-aarch64.so.1 \
sudo ln -sf /usr/aarch64-linux-gnu/lib/ld-linux-aarch64.so.1 \
/lib/ld-linux-aarch64.so.1

echo "CARGO_TARGET_AARCH64_UNKNOWN_LINUX_GNU_LINKER=/usr/bin/aarch64-linux-gnu-gcc-10" >> ${GITHUB_ENV}
echo "QEMU_LD_PREFIX=/usr/aarch64-linux-gnu" >> ${GITHUB_ENV}

- name: Install cross compilation toolchain (riscv64)
if: matrix.config.target == 'riscv64gc-unknown-linux-gnu'
run: |
rustup target add riscv64gc-unknown-linux-gnu

sudo apt update
sudo apt install -yq --no-install-suggests --no-install-recommends \
binfmt-support g++-10-riscv64-linux-gnu \
gcc-10-riscv64-linux-gnu libc6-riscv64-cross qemu qemu-user \
qemu-user-binfmt

sudo ln -sf /usr/riscv64-linux-gnu/lib/ld-linux-riscv64-lp64d.so.1 \
/lib/ld-linux-riscv64-lp64d.so.1

echo "CARGO_TARGET_RISCV64GC_UNKNOWN_LINUX_GNU_LINKER=/usr/bin/riscv64-linux-gnu-gcc-10" >> ${GITHUB_ENV}
echo "QEMU_LD_PREFIX=/usr/riscv64-linux-gnu" >> ${GITHUB_ENV}

- name: Write git_submodule_status.txt
run: git submodule status --recursive > git_submodule_status.txt

Expand Down Expand Up @@ -267,6 +310,8 @@ jobs:
"aarch64-apple-darwin" = "aarch64-apple-darwin"
"x86_64-unknown-linux-gnu" = "x86_64-unknown-linux-musl"
"aarch64-unknown-linux-gnu" = "aarch64-unknown-linux-musl"
# Unlike aarch64, the riscv64 sccache binary is not static, so use the host architecture one.
"riscv64gc-unknown-linux-gnu" = "x86_64-unknown-linux-musl"
"x86_64-pc-windows-msvc" = "x86_64-pc-windows-msvc"
}['${{ matrix.config.target }}']
$basename = "sccache-$version-$platform"
Expand Down
10 changes: 10 additions & 0 deletions build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,16 @@ fn build_v8(is_asan: bool) {
maybe_install_sysroot("i386");
maybe_install_sysroot("arm");
}
if target_arch == "riscv64" {
gn_args.push(r#"target_cpu="riscv64""#.to_string());
// Cross compiling needs to set v8_target_cpu
gn_args.push(r#"v8_target_cpu="riscv64""#.to_string());
if target_os == "linux" {
gn_args.push("use_sysroot=true".to_string());
maybe_install_sysroot("riscv64");
maybe_install_sysroot("amd64");
}
}

let target_triple = env::var("TARGET").unwrap();
// check if the target triple describes a non-native environment
Expand Down
Loading