WEB3-380: Fix decode_seal (#494)

Cargo.toml

@@ -3,7 +3,7 @@ resolver = "2"
 members = ["crates/*", "crates/aggregation/guest", "crates/ffi/guests"]
 
 [workspace.package]
-version = "1.4.0"
+version = "1.4.1"
 edition = "2021"
 license = "Apache-2.0"
 homepage = "https://risczero.com/"
@@ -12,9 +12,9 @@ repository = "https://github.com/risc0/risc0-ethereum/"
 [workspace.dependencies]
 # Intra-workspace dependencies
 risc0-aggregation = { version = "0.3.0", default-features = false, path = "crates/aggregation" }
-risc0-build-ethereum = { version = "1.4.0", default-features = false, path = "build" }
-risc0-ethereum-contracts = { version = "1.4.0", default-features = false, path = "contracts" }
-risc0-forge-ffi = { version = "1.4.0", default-features = false, path = "crates/ffi" }
+risc0-build-ethereum = { version = "1.4.1", default-features = false, path = "build" }
+risc0-ethereum-contracts = { version = "1.4.1", default-features = false, path = "contracts" }
+risc0-forge-ffi = { version = "1.4.1", default-features = false, path = "crates/ffi" }
 risc0-op-steel = { version = "0.2.0", default-features = false, path = "crates/op-steel" }
 risc0-steel = { version = "2.0.0-rc.2", default-features = false, path = "crates/steel" }
 

contracts/src/groth16.rs

@@ -169,4 +169,17 @@ mod tests {
         .unwrap();
         receipt.verify(image_id).unwrap();
     }
+
+    #[test]
+    #[cfg(feature = "unstable")]
+    fn test_decode_fake_seal() {
+        use crate::receipt::decode_seal;
+        use risc0_zkvm::ReceiptClaim;
+
+        let fake_claim = ReceiptClaim::ok(Digest::default(), vec![]).digest();
+        let mut seal = vec![];
+        seal.extend_from_slice(&[0u8; 4]);
+        seal.extend_from_slice(fake_claim.as_bytes());
+        decode_seal(seal.into(), fake_claim, vec![]).unwrap();
+    }
 }

contracts/src/receipt.rs

@@ -101,7 +101,6 @@ pub fn decode_seal_with_claim(
     let selector = [seal[0], seal[1], seal[2], seal[3]];
     let selector = Selector::from_bytes(selector)
         .ok_or_else(|| DecodingError::UnsupportedSelector(selector))?;
-    let verifier_parameters = selector.verifier_parameters_digest()?;
     match selector.get_type() {
         SelectorType::FakeReceipt => {
             let receipt = risc0_zkvm::Receipt::new(
@@ -111,11 +110,13 @@ pub fn decode_seal_with_claim(
             Ok(Receipt::Base(receipt))
         }
         SelectorType::Groth16 => {
+            let verifier_parameters = selector.verifier_parameters_digest()?;
             let receipt =
                 decode_groth16_seal(seal, claim, journal.into(), Some(verifier_parameters))?;
             Ok(Receipt::Base(receipt))
         }
         SelectorType::SetVerifier => {
+            let verifier_parameters = selector.verifier_parameters_digest()?;
             let receipt = decode_set_inclusion_seal(&seal, claim, verifier_parameters)?;
             Ok(Receipt::SetInclusion(receipt))
         }