Skip to content

fix: Resolve optional Thumbnails when requesting PlaylistItems #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danperks
Copy link

This pull request includes several important changes to the YoutubeKit API models to enhance flexibility and robustness. The changes primarily focus on making certain fields optional and adding new fields to better represent the data structure.

Enhancements to PlaylistItem and related models:

@danperks
Copy link
Author

Could be a dupe of #45 actually, my bad!

@Tibimac
Copy link
Contributor

Tibimac commented May 13, 2025

Could be a dupe of #45 actually, my bad!

@danperks It's not a real duplicate because your PR goes further and IHMO yours could be merged while the #45 could be canceled and closed.
Nevertheless I wonder why you renamed the playlistID property to playlistId because to keep the consistency across the project ID have to stay in uppercase.
Moreover you also left a duplicate; there is both channelId and channelID.
In order to help, I created the PR to solve those issues (danperks#3). Once you'll merge it, this PR should be updated too (I hope so ^^).

@rinov Can you please plan to merge this PR (and apply the patch from my PR above if not yet merged by @danperks in this PR) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants