feat: implement vsock configuration for VMs #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hey @alexandrebrg, is this repository maintained? I have this and a couple of other branches that I'd like to get merged in here. For now we're maintaining an internal fork, but I'd like to use the public version if we can get these changes in. |
Member
|
Hi @norwoodj, my apologies for the delay. Thank you for the contribution :) |
alexandrebrg
requested changes
Oct 27, 2025
Member
alexandrebrg
left a comment
alexandrebrg
left a comment
There was a problem hiding this comment.
Small changes otherwise look good to me 👍
Comment on lines
+56
to
+60
| VsockBuilder::new() | ||
| .with_guest_cid(3) | ||
| .with_uds_path("/tmp/fc.sock".to_string()) | ||
| .try_build() | ||
| .unwrap(); |
Member
There was a problem hiding this comment.
Rather than having a panic with no context (if it fails), please add the expected behaviour in a expect
Suggested change
| VsockBuilder::new() | |
| .with_guest_cid(3) | |
| .with_uds_path("/tmp/fc.sock".to_string()) | |
| .try_build() | |
| .unwrap(); | |
| VsockBuilder::new() | |
| .with_guest_cid(3) | |
| .with_uds_path("/tmp/fc.sock".to_string()) | |
| .try_build() | |
| .expect("Minimal build should be valid") |
| #[test] | ||
| #[should_panic] | ||
| fn partial_kernel() { | ||
| VsockBuilder::new().with_guest_cid(3).try_build().unwrap(); |
Comment on lines
+105
to
111
| impl Default for Executor { | ||
| fn default() -> Self { | ||
| Self::new() | ||
| } | ||
| } | ||
|
|
||
| impl Executor { |
Member
There was a problem hiding this comment.
Suggested change
| impl Default for Executor { | |
| fn default() -> Self { | |
| Self::new() | |
| } | |
| } | |
| impl Executor { | |
| #[derive(Default)] | |
| impl Executor { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Description
Implements vsock for firecracker VMs spawned by firepilot by adding the configuration and API call to the firecracker server.
✅ Checks