Repository navigation
Conversation
The order in a Manage dialog is the order they appear in - the Macros menu, the right-click Command submenu, the sidebar - and it was the one property of a preset you could not set. PresetStore.swap() rather than a move: one list holds all three categories interleaved, so the two entries being exchanged are neighbours within their category but rarely adjacent in the file. Swapping positions leaves every other preset untouched, and a test asserts Commands do not shuffle when a Macro moves past another. Offered for all three categories rather than Macros alone: same dialog, same code, and "why can I order Macros but not Commands?" is a worse answer than the feature. Code assisted by Opus 5.
The code takes the posix path there - ptyprocess, $SHELL - which is the same one verified on Linux, so it should work. Nobody has ever run it on a Mac, which is the only reason that sentence has a "should" in it. Code assisted by Opus 5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
macos-latestto the test matrix.macOS takes the posix PTY path —
ptyprocess,$SHELL— the same oneverified under WSL, so the suite is expected to pass. It has never actually
been run there, which is the point of this PR.
Known gaps this will not catch, because they are missing features rather
than failures:
known_shells()returns[]off Windows, so File → NewTerminal offers only "Default Shell"; and the split shortcuts use
Alt+Shift+…, which is Option on macOS.🤖 Generated with Claude Code
https://claude.ai/code/session_01M8UgLA68nRCYg3qFTyW8ms