fix: implement PartialOrd correctly for types implementing Ord (#295)

* chore: update Cargo.lock * fix: implement PartialOrd in a way that makes clippy happy
rigetti · Oct 11, 2023 · 0823bf7 · 0823bf7
1 parent 87c224d
commit 0823bf7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/quil-rs/src/instruction/control_flow.rs b/quil-rs/src/instruction/control_flow.rs
@@ -92,7 +92,7 @@ impl std::hash::Hash for TargetPlaceholder {
 
 impl PartialOrd for TargetPlaceholder {
     fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {
-        self.address().partial_cmp(&other.address())
+        Some(self.cmp(other))
     }
 }
 

diff --git a/quil-rs/src/instruction/qubit.rs b/quil-rs/src/instruction/qubit.rs
@@ -83,7 +83,7 @@ impl PartialEq for QubitPlaceholder {
 
 impl PartialOrd for QubitPlaceholder {
     fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {
-        self.address().partial_cmp(&other.address())
+        Some(self.cmp(other))
     }
 }