Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update README with build instruction #6

Merged
merged 3 commits into from
Nov 17, 2022

Conversation

Shadow53
Copy link
Contributor

@Shadow53 Shadow53 commented Nov 9, 2022

A couple things to note:

  • I did my best to manually validate that these commands are correct
  • That said, when I tried to automatically verify using a Dockerfile, I ran into errors when compiling libquilc.so because gcc -dynamiclib is not a valid flag:
#0 34.66 * gcc -dynamiclib -o libquilc.dylib libquilc.c -lsbcl
#0 34.69 cc1: warning: unrecognized gcc debugging option: y
#0 34.69 cc1: warning: unrecognized gcc debugging option: n
#0 34.69 cc1: warning: unrecognized gcc debugging option: m
#0 34.69 cc1: warning: unrecognized gcc debugging option: i
#0 34.69 cc1: warning: unrecognized gcc debugging option: c
#0 34.69 cc1: warning: unrecognized gcc debugging option: l
#0 34.69 cc1: warning: unrecognized gcc debugging option: i
#0 34.69 cc1: warning: unrecognized gcc debugging option: b

@Shadow53 Shadow53 requested review from MarquessV and notmgsk November 9, 2022 00:49
Copy link
Contributor

@MarquessV MarquessV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RE: the gcc issue. -dynamiclib is a darwin only flag.

Copy link
Contributor

@MarquessV MarquessV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is worth a ✅ from Mark given he's the one who knows the most about it, but these directions align with my notes and state of my machine.

@notmgsk
Copy link
Contributor

notmgsk commented Nov 14, 2022

Just a couple comments. Maybe something to do in a follow-on issue would be to collect those build instructions into a Dockerfile (or similar).

I could see it being useful for us to pin the various quil-lang repos to particular revs, so that our instructions are never out-of-date.

@Shadow53 Shadow53 requested a review from notmgsk November 17, 2022 00:50
@notmgsk notmgsk merged commit 7decf79 into initial-api Nov 17, 2022
@Shadow53 Shadow53 mentioned this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants