Skip to content

fix: quote sysctl keys in config.toml template, so that the TOML is properly parsed by gitlab-runner #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2025
Merged

fix: quote sysctl keys in config.toml template, so that the TOML is properly parsed by gitlab-runner #403

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fed079
fix: correct sysctls usage
gwarf Oct 13, 2025
ce3a3a9
fix: use a proper test on extra_configs presence
gwarf Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions templates/config.toml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,17 +124,17 @@ sentry_dsn = "{{ gitlab_runner_sentry_dsn }}"
{% if gitlab_runner.docker_security_opt is defined %}
security_opt = {{ gitlab_runner.docker_security_opt | tojson }}
{% endif %}
{% if gitlab_runner.extra_configs %}
{% if gitlab_runner.extra_configs is defined %}
{% if 'runners.docker' in gitlab_runner.extra_configs %}
{% for key, value in gitlab_runner.extra_configs['runners.docker'].items() %}
{{ key }} = {{ value | tojson }}
{% endfor %}
{% endif %}
{#### [[runners.docker.sysctls]] section ####}
{#### [runners.docker.sysctls] section ####}
{% if 'runners.docker.sysctls' in gitlab_runner.extra_configs %}
[runners.docker.sysctls]
{% for key, value in gitlab_runner.extra_configs['runners.docker.sysctls'].items() %}
{{ key }} = {{ value | tojson }}
"{{ key }}" = {{ value | tojson }}
{% endfor %}
{% endif %}
{% endif %}
Expand Down
Loading