Add support for configuring runner through template #400
+356
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leonidas Avdelas <[email protected]>
|
LGTM. I like it. It is not breaking anything but is just here as 3rd way to do it. I'd merge that as is. Even if you missed something in the template, it is not critical because things can be added if needed. Very good job! |
Signed-off-by: Leonidas Avdelas <[email protected]>
|
Sounds fair, I am removing it from draft state. |
|
I guess people will love this new feature. If you are keen in getting a maintainer of this repo, just say a word. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first attempt at creating the configuration from a template. I am not sure this would 100% work for all cases, so I would appreciate any feedback on how you would see this feature designed.
Closes #393