Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated umbraco-package JS path to work on case-sensitive systems. #71

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

kevin9092
Copy link
Contributor

Issue

The "js" file path entry for umbraco-package.json in the Umbraco.Community.BlockPreview.UI project has mismatching casing when compared to the actual folder path. This breaks on case-sensitive operating systems.

Fix

The file path has been updated to match the casing of the folder path. This should now be working as expected, tested via Ubuntu WSL.

Fixes #68

@rickbutterfield
Copy link
Owner

Thank you for all your hard work on this package @kevin9092!

@rickbutterfield rickbutterfield merged commit 7fab425 into rickbutterfield:v2/dev Oct 3, 2024
@umbrabot
Copy link

umbrabot commented Dec 4, 2024

Hi there @kevin9092!

First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇

Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉

In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you!
This year's swag is a custom designed notebook and custom Umbraco Hacktoberfest sticker:

image

As an alternative choice, you can opt-out of receiving anything and ask us to help improve the planet instead by planting a tree on your behalf. 🌳

Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before December 25th, 2024, 23:59:00 UTC.

Following this date we'll be sending out all the swag, but please note that it might not reach your doorstep for a few weeks/months, so please bear with us and be patient 🙏

The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help!

Kind regards,
The various Umbraco teams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants