ns16550a: Buy back 16088 asy can overrun TX on interrupt race #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfmooney
reviewed
Dec 5, 2023
pfmooney
left a comment
pfmooney
left a comment
There was a problem hiding this comment.
One small nit, but yeah, looks fine for the commit to bear my name. Thanks for checking.
| struct nsasyncline *nsasync = ns16550->ns16550_priv; | ||
| int ret_status = DDI_INTR_UNCLAIMED; | ||
| uchar_t interrupt_id, lsr; | ||
| uchar_t lsr; |
There was a problem hiding this comment.
Move this inside the for loop and make it const there like in upstream?
richlowe
force-pushed
the
arm64/asy-buyback
branch
from
13f6382 to
774011c
Compare
pfmooney
approved these changes
Dec 5, 2023
|
Might want to wait until the 16107 fix lands |
(includes the later fix for 16107 asy VERIFY too strong in face of polledio)
richlowe
force-pushed
the
arm64/asy-buyback
branch
from
774011c to
0329712
Compare
Owner
Author
Done |
pfmooney
approved these changes
Dec 5, 2023
|
Thanks for waiting. Sorry about the extra trouble. |
Owner
Author
|
@hadfl says this gets stally on rpi (though it doesn't seem to on qemu). That said, it seems to be stalling for interrupts, which we've seen go ok on qemu and not raspberry pi before. I don't immediately see anything I did wrong merging with Patrick, though? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes Patrick's fix for illumos#16088 and puts it into ns16550 as well (which is an almost direct copy of asy for mysterious reasons, remember).
@hadfl @citrus-it It seems best to double check this on raspberry pi, though I still wish we knew why this wasn't just asy(4D) in the first place
@pfmooney can you confirm you're ok with my putting your name on this, since it's directly taken out of your fix?