sqlite3-using idmap (sans conversions) #180
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I4fa781283b4bffc71cdebe522272b9c65cd52dac
Change-Id: I1725cd25c2446c78530e1b4dbc23f8126a48a002
- exception lists (many of) - deliver the 64bit amd64 libs in the conventional place - aarch64 build bits
This does what amounts to the bare minimum in using sqlite3. Worthwhie improvements like parameter binding rather than printf'd queries, and using the typed column access API rather than passing things through char*. Take the db mutex across calls where we want the error message string, which the documentation implies is necessary (rather than there being a thread-local).
Owner
Author
|
@jasonbking this is the sqlite3 stuff I was talking about. I don't know Matt's github info, if he wants to look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sort of straw-man conversion of idmap to sqlite, without a conversion utility (the arm64-port has no ABI limitations as yet).
@Bill-Sommerfeld does this follow approximately what you were hoping? Do you have ideas for an application_id? The best in my head is some variant on
0x...11105...in the sense of getting at least "illumos" in there.0x111051dwould work, so would just a counter.We need this in the arm gate more urgently than x86, since it seems a 64bit sqlite2 is broken.