Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiny Fixes PR #32

Open
wants to merge 4 commits into
base: make-vercel-build-shutup
Choose a base branch
from
Open

Tiny Fixes PR #32

wants to merge 4 commits into from

Conversation

SeniorMars
Copy link
Contributor

Overview

This PR addresses several small improvements and optimizations across the application, focusing on code structure, type safety, and performance.

Key Changes

Code Structure and Type Safety

  • Moved FormDataType to a centralized types.tsx file for better type management
  • Updated imports across the project to reference the new centralized type
  • Simplified and cleaned up server-side Supabase client creation
  • Removed unnecessary comments and simplified code structure

Performance Optimization

  • Added sizes prop to Next.js Image components to improve page load performance
  • Added priority prop to critical above-the-fold images
  • Updated font configuration for better loading
  • Removed unused imports and dependencies

React and Next.js Improvements

  • Simplified React component structures
  • Removed unnecessary Suspense components
  • Updated page and component rendering logic
  • Improved type checking and import consistency

Specific Improvements

  • Centralized FormDataType in app/types.tsx
  • Updated PostListingFormProvider to use new type import
  • Simplified Supabase server client creation
  • Added image performance optimizations across components

Notes

  • Tested across different screen sizes
  • Verified image loading and rendering
  • Maintained existing functionality while improving code quality

TODO

  • Continue code cleanup in future PRs
  • Further optimize performance where possible

@SeniorMars
chore: Add priority and sizes to Next.js Image components
a491fdd 
- Added `sizes` prop to improve page performance
- Added `priority` prop to critical above-the-fold images
- Ensured proper image loading configuration
@SeniorMars
chore: Optimize layout and font loading
73b601c 
- Fixed font configuration in layout
- Removed duplicate code
- Improved Next.js layout structure
@SeniorMars
refactor: Clean up page and component structures
cc9a5d0 
- Simplified page components
- Removed unnecessary comments
- Improved code readability
@vercel Vercel
Copy link

vercel bot commented Feb 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bunkmate-but-better ❌ Failed (Inspect) Feb 21, 2025 8:26pm

@SeniorMars
Copy link
Contributor Author

Last three prs wtf.

@SeniorMars SeniorMars changed the base branch from main to make-vercel-build-shutup February 21, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SeniorMars