Fix incomplete results for large collections (>2500 items)#7
Merged
Conversation
Documents the approach for supporting collections up to 5,000 items: raise maxPages cap, fix pagination.items reporting, fix broken truncation detection, align collections cache TTL to 45 minutes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… total - Raise maxPages default from 25 to 50 (supports up to 5000 items) - Fix pagination.items to return real Discogs total, not truncated count - Fix broken truncation detection (was comparing clamped value to itself) - Fix collections KV TTL from 30min to 45min to match intended cache window - Add tests for truncation behaviour in CachedDiscogsClient Closes #6 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ctions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
🚀 Deploy succeeded! Your changes have been deployed to production. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6
Summary
maxPages25→50)pagination.itemsto report the real Discogs total, not the truncated countcollectionsKV TTL from 30min to 45min to match intended cache windowget_collection_statsandsearch_collectionoutput when a collection exceeds the indexed portionTest plan
CachedDiscogsClienttests)get_collection_statsshould report correct total;search_collectionshould find all matches🤖 Generated with Claude Code