Fix logic and memory leak

go.mod

@@ -0,0 +1,3 @@
+module tokopedia/debuggingworkshop
+
+go 1.17

main.go

@@ -37,12 +37,15 @@ func sender(c chan signalData) {
 }
 
 func receiver(c chan signalData) {
+	// go tool pprof -alloc_space http://localhost:6060/debug/pprof/heap
+	// memory leak caused by repeated NewTimer instantiation. instantiate only once.
+	timeout := time.NewTimer(time.Second)
 	for {
 		select {
 		case signalData := <-c:
 			signalData.status = validateSignal(signalData.signal)
 			fmt.Println("Receiving Signal ", signalData.signal, " with status ", signalData.status)
-		case <-time.After(time.Second * 1):
+		case <-timeout.C:
 			fmt.Println("Got timeout while receiving the signal")
 			return
 		}
@@ -100,7 +103,7 @@ func evaluateNode(node1, node2 int) int {
 	case node2 < node1:
 		return 0
 	default:
-		return 0
+		return 1
 	}
 }
 

main_test.go

@@ -28,6 +28,20 @@ func Test_validateSignal(t *testing.T) {
 			},
 			want: "bad",
 		},
+		{
+			name: "bad signal 2",
+			args: args{
+				signal: []int{1, 1, 0, 0, 1, 0},
+			},
+			want: "bad",
+		},
+		{
+			name: "good signal 2",
+			args: args{
+				signal: []int{0, 1, 0, 0, 1, 1},
+			},
+			want: "good",
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {