Prep for upcoming changes to the Abstract Beamline Interface#3
Merged
Conversation
pkeller
commented
Sep 22, 2025
pkeller
commented
- In the very near future, there will be two changes on the Java side:
- Package names in the ABI will change
- ABI types and Py4jMessage will be imported into the default JVM view on the Java side instead of the Python side; Python code should use the unqualified class/interface names
- This commit makes the Python code that interacts with the GPhL workflow insensitive to those changes
- In the very near future, there will be two changes on the
Java side:
- Package names in the ABI will change
- ABI types and Py4jMessage will be imported into the
default JVM view on the Java side instead of the
Python side; Python code should use the unqualified
class/interface names
- This commit makes the Python code that interacts with
the GPhL workflow insensitive to those changes
Author
|
Hopefully this is self-explanatory: I worked out how to get hold of the default Py4J JVM view on the Java side, and I can set up the imports there very easily. I have left the references to the constructors in astra.messagebus.messages.* as they are for the time being. As we discussed, we can look at those in the future, maybe for version 3 of the ABI. |
- Remove cruft that got into the code by accident
rhfogh
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.