[OPENJDK-3856] Remove broken support for appsrc run.sh #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmtd
force-pushed
the
OPENJDK-3856-vestigal-run
branch
from
bbf9e78 to
944bdc0
Compare
https://issues.redhat.com/browse/OPENJDK-3856 Signed-off-by: Jonathan Dowland <[email protected]>
jmtd
force-pushed
the
OPENJDK-3856-vestigal-run
branch
from
944bdc0 to
664fa6a
Compare
|
rebased PR to trigger a new GHA run |
|
finally green lights on GHA for this PR @jerboaa , when you have time please re-look :) |
|
Just some notes on how I re-checked that the feature doesn't work 1c4d482 is a basic test of the functionality the result is something like |
jerboaa
approved these changes
Sep 15, 2025
|
GH bot labeller failures are a bit annoying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/OPENJDK-3856
Remove the broken implementation of supporting
src/run.shas an alternative run script in app sources. The feature was broken accidentally in 2018 and has never worked in a UBI image. Users can overrideRUN(orENTRYPOINT) instead.The logic for the feature complicates the fix for [OPENJDK-2968] Runtime images don't properly support JAVA_ARGS (#589 ).