Changing the way to interact with JGroups in the ResourceAdapter #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Obtaining a BroadCastEndpointFactory instead of a JChannel to connect to JGroups to avoid issue and leak with JChannel lifecyle.
pferraro
reviewed
Aug 24, 2017
| Object o = aClass.newInstance(); | ||
| Method m = aClass.getMethod("locateChannel", new Class[]{String.class}); | ||
| return (JChannel) m.invoke(o, name); | ||
| Method m = aClass.getMethod("locateBroadcastEndpointFactory", new Class[]{String.class}); |
There was a problem hiding this comment.
I worry about how this change affects compatibility. Existing usage of the jgroupsChannelLocatorClass property will break, as the value provided will not have this method.
This change isn't strictly required to fix https://issues.jboss.org/browse/WFLY-9246, so long as the messaging-activemq subsystem is able to override the broadcast endpoint logic used by the resource adapter logic, which 1692f78 already allows.
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obtaining a BroadCastEndpointFactory instead of a JChannel to connect to JGroups to avoid issue and leak with JChannel lifecyle.