Validate versions #84
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: empovit The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
empovit
force-pushed
the
validate-versions
branch
from
36b7760 to
59dfd02
Compare
empovit
force-pushed
the
validate-versions
branch
from
59dfd02 to
c6579dc
Compare
* Remove the enforcement for chart version in main branch * Enforce a semver chart and image version in release branches * Always align the image and chart version
empovit
force-pushed
the
validate-versions
branch
from
c6579dc to
a3f70d1
Compare
yakovbeder
left a comment
yakovbeder
left a comment
There was a problem hiding this comment.
HI @empovit . A couple of issues I noticed:
1. 🔴 Missing yq installation
ubuntu-latest runners don't include yq by default. The workflow will fail at the first yq eval command:
/usr/bin/bash: line 1: yq: command not found
Suggested fix — add a step before using yq:
- name: Install yq
uses: mikefarah/yq@v4
2. 🟡 --check-version-increment=false applied globally
The helm-lint-test.yaml workflow runs on all PRs, so disabling the version increment check means PRs to main can now merge chart changes without bumping Chart.yaml version. This could undermine release integrity.
Suggestion — scope the flag to release branches only:
- name: Run chart-testing (lint)
run: |
if [[ "${{ github.base_ref }}" =~ ^release- ]]; then
ct lint --config deployment/ct.yaml --check-version-increment=false
else
ct lint --config deployment/ct.yaml
fiAlternatively, keep the increment check enabled formainand rely on the newversion-test.yamlonly for release branches.
|
Thanks @yakovbeder ! However,
Let's keep this workflow until we figure out something better. |
|
Agreed. Then it's /lgtm |
|
/lgtm |
openshift-merge-bot
bot
merged commit 1f7116f
into
rh-ecosystem-edge:main
|
/help |
|
/cherrypick release-0.2.3 |
|
@empovit: new pull request created: #91 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick release-0.2.4 |
|
@empovit: new pull request created: #92 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@empovit: new pull request created: #93 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-0.2.3 |
|
@empovit: new pull request could not be created: failed to create pull request against rh-ecosystem-edge/console-plugin-nvidia-gpu#release-0.2.3 from head openshift-cherrypick-robot:cherry-pick-84-to-release-0.2.3: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-84-to-release-0.2.3."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
No description provided.