Skip to content

Conversation

@empovit
Copy link
Member

@empovit empovit commented Dec 20, 2025

  • Update OpenShift Console SDK from 0.0.11 to 1.4.0
  • Upgrade PatternFly components from v4 to v6
  • Align with OpenShift 4.20 console plugin template
  • Update Node.js base image from 16 to 20
  • Modernize webpack and TypeScript configuration
  • Add code quality tools (prettier, stylelint)
  • Enhance i18n support with custom lexers
  • Improve deployment security contexts and resource defaults
  • Move nginx config to Helm configmap template
  • Clean up obsolete files (default.conf, duplicate configs)
  • Update compatibility table
  • Complete PatternFly v6 code migration
  • Add SCSS support for PatternFly v6 styles
  • Add all DCGM metrics provided by default

@openshift-ci
Copy link

openshift-ci bot commented Dec 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: empovit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

- Update OpenShift Console SDK from 0.0.11 to 1.4.0
- Upgrade PatternFly components from v4 to v6
- Align with OpenShift 4.20 console plugin template
- Update Node.js base image from 16 to 20
- Modernize webpack and TypeScript configuration
- Add code quality tools (prettier, stylelint)
- Enhance i18n support with custom lexers
- Improve deployment security contexts and resource defaults
- Move nginx config to Helm configmap template
- Clean up obsolete files (default.conf, duplicate configs)
- Update compatibility table
- Complete PatternFly v6 code migration
- Add SCSS support for PatternFly v6 styles
- Add all DCGM metrics provided by default
@empovit empovit force-pushed the update-for-ocp-4.19 branch from c5e04e2 to cf397a3 Compare December 20, 2025 19:46
@empovit
Copy link
Member Author

empovit commented Dec 20, 2025

/hold

@empovit empovit changed the title Upgrade plugin for OpenShift 4.19+ compatibility [WIP] Upgrade plugin for OpenShift 4.19+ compatibility Dec 26, 2025
@yakovbeder
Copy link
Collaborator

yakovbeder commented Dec 28, 2025

Request changes:

  • i18n-scripts/lexers.js: remove stray debug console.log(1) from CustomJSONLexer.
  • i18n-scripts/build-i18n.sh: CLI invocation includes [-oc] (looks like usage-doc syntax); fix to valid i18next-parser args so yarn i18n works and scripts/test-i18n.sh leaves locales/ clean.
  • src/components/PodStatus/PodStatus.tsx: links use pod.metadata.nam (typo); should be pod.metadata.name (otherwise generated URLs are broken).
  • src/components/PodStatus/PodStatus.tsx: Unschedulable check uses condition.status === 'False'; should be True (or remove the status check and key off reason/message).
  • tsconfig.json: strict changed to false; if temporary for migration, please add follow-up to re-enable strictness (or keep strictNullChecks enabled).

Verification needed:

  • Dockerfile/nginx changes: entrypoint + nginx.conf moved to Helm ConfigMap; please confirm container starts on OCP 4.19+ as non-root and TLS cert mount path matches nginx.conf (/var/cert/tls.{crt,key}).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants