Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request improves version management for the meshcore-proxy package using setuptools_scm. The changes ensure proper versioning across different build contexts (local development, CI/CD, and Docker builds).
Changes:
- Added alphabetical ordering to imports in the main package init file
- Configured a fallback version for setuptools_scm when no git tags are available
- Added version passing mechanism for Docker builds via build arguments and environment variables
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/meshcore_proxy/init.py | Reordered imports alphabetically (PackageNotFoundError before version) |
| pyproject.toml | Added fallback_version configuration for setuptools_scm |
| Dockerfile | Added ARG and ENV for version passing to setuptools_scm during Docker builds |
| .github/workflows/ci.yml | Added version setting steps for both package builds and Docker image builds when building from tags |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.