-
Notifications
You must be signed in to change notification settings - Fork 3
Fix PyPI release pipeline with dynamic versioning from git tags #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,9 @@ | ||
| """MeshCore Proxy - TCP proxy for MeshCore companion radios.""" | ||
|
|
||
| __version__ = "0.1.0" | ||
| from importlib.metadata import version, PackageNotFoundError | ||
|
|
||
| try: | ||
| __version__ = version("meshcore-proxy") | ||
| except PackageNotFoundError: | ||
| # Package is not installed | ||
| __version__ = "0.0.0.dev0" | ||
|
Comment on lines
+5
to
+9
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation mentions tags can follow the pattern
vX.Y.ZorvX.Y.Z-alpha, but the tag regex also accepts-betaand-rc[0-9]+suffixes. The documentation should be updated to mention all supported tag formats for completeness. Consider updating line 336 to say: "Tags should follow the patternvX.Y.Z,vX.Y.Z-alpha,vX.Y.Z-beta, orvX.Y.Z-rc<number>(e.g.,v0.4.0,v0.4.0-alpha,v0.4.0-beta,v0.4.0-rc1)"