fix: Weird snap behavior (Android) #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the quick fix, I'm using your branch on my project! This PR fixes #16 I've opened |
|
Closing as discussed on #7 |
|
@rgommezz I've made a new Snack that can explain my point: |
|
@rgommezz I can confirm that I've the same issue and PR from @djorkaeffalexandre works like a charm. Can you maybe merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rgommezz
Motivation
If you refer to my Snack repo here, you can see that have some weird behaviors at Android, sometimes when you try to go to an intermediate snap, it open at the latest snap point but all the values are at the right point.
I just rollback some commits searching for some code that's working and found this piece of code that fixes the issue, so, I just put it back.
If you have a better solution just let me know.
Thanks in advance.