Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provenance + audio replay #509

Merged
merged 36 commits into from
Jan 11, 2025
Merged

Provenance + audio replay #509

merged 36 commits into from
Jan 11, 2025

Conversation

ZachCutler04
Copy link
Contributor

@ZachCutler04 ZachCutler04 commented Dec 13, 2024

Does this PR close any open issues?

Closes #476

Give a longer description of what this PR addresses and why it's needed

Adds in replay functionality, accessible via the provenance tab in the analysis view. Replay should work with both/one of audio and provenance data, though audio will only work via firebase (provenance will work for both)

Provide pictures/videos of the behavior before and after these changes (optional)

Are there any additional TODOs before this PR is ready to go?

Main todo is that we don't check for past versions of config currently, so old configs may run into problems during replay.

Copy link
Contributor

@JackWilb JackWilb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes of things to fix:

  • Need to disable reviewer steps panel in replay
  • Update play pause button
  • Design pass on the replay timeline visualization
  • Disable next participant button in study browser
  • Disable next participant button in replay footer

@ZachCutler04 ZachCutler04 merged commit b0b180d into dev Jan 11, 2025
4 checks passed
@ZachCutler04 ZachCutler04 deleted the zc/replay branch January 11, 2025 19:35
@JackWilb JackWilb mentioned this pull request Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants