Skip to content

Conversation

@SudevKiyadaTR
Copy link
Contributor

What's in this pull request

Exposes width as ContainerWidth | string type.

@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2025

⚠️ No Changeset found

Latest commit: f156926

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@SudevKiyadaTR SudevKiyadaTR requested review from MinamiFunakoshiTR and removed request for hobbes7878 December 5, 2025 11:30
Copy link
Contributor

@MinamiFunakoshiTR MinamiFunakoshiTR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you add a short documentation on this to say width and height are both configurable but default to X value, and that width can either be a container width class or a CSS width value?

@SudevKiyadaTR
Copy link
Contributor Author

Done. Also adds a light border around the container when showDebugInfo is set to true. This is to help see the container sizing against white background.

@MinamiFunakoshiTR
Copy link
Contributor

Done. Also adds a light border around the container when showDebugInfo is set to true. This is to help see the container sizing against white background.

sounds good. thanks!

@SudevKiyadaTR SudevKiyadaTR merged commit fe3e79b into sudev-scroller-lottie Jan 12, 2026
@SudevKiyadaTR SudevKiyadaTR deleted the sk-lottie-test branch January 14, 2026 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants