Skip to content

Feat/wunderkind smart tag #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AhmedLukmanTR wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Feat/wunderkind smart tag #184

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e62fe16
chore: Install dependencies with npm i
AhmedLukmanTR Oct 11, 2024
c609095
feat: Add WunderkindAd component to handle ad slot display based on u…
AhmedLukmanTR Oct 11, 2024
7b111af
refactor: Remove unnecessary ad slot display code
AhmedLukmanTR Oct 11, 2024
a0f382f
fix: replace svelte:head with programmatic script injection
AhmedLukmanTR Oct 22, 2024
cad28f1
feat: Add WunderkindAd component export
AhmedLukmanTR Oct 22, 2024
e32b378
fix: Remove unnecessary p letter
AhmedLukmanTR Oct 24, 2024
e747a1a
docs: Add WunderkindAd component story docs
AhmedLukmanTR Oct 24, 2024
af6a222
docs: Update WunderkindAd component story to include AdScripts
AhmedLukmanTR Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 22 additions & 0 deletions src/components/AdSlot/WunderkindAd.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<script lang="ts">
import { onMount } from 'svelte';

onMount(() => {
// Check user login status
let isLoggedIn = localStorage.getItem('ArcId.USER_PROFILE') !== null;
if (!isLoggedIn) {
const script = document.createElement('script');
script.textContent = `p
Copy link
Member

@hobbes7878 hobbes7878 Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the p here intentional?

Copy link
Collaborator Author

@AhmedLukmanTR AhmedLukmanTR Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, apologies, that was a mistype. I will rectify that.

freestar.config.enabled_slots.push({
placementName: 'reuters_1x1_bouncex',
slotId: 'reuters_1x1_bouncex',
});
`;
script.setAttribute('data-cfasync', 'false');
script.type = 'text/javascript';
document.head.appendChild(script);
}
});
</script>

<div id="reuters_1x1_bouncex"></div>
Copy link
Member

@hobbes7878 hobbes7878 Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain if this div displays an ad, how that behaves and how this ad unit interplays with our existing InlineAd component, if at all? E.g., should we prefer this ad unit and fallback to an InlineAd if the user is not logged in? Something else?

1 change: 1 addition & 0 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ export { default as Theme, themes } from './components/Theme/Theme.svelte';
export { default as ToolsHeader } from './components/ToolsHeader/ToolsHeader.svelte';
export { default as Video } from './components/Video/Video.svelte';
export { default as Visible } from './components/Visible/Visible.svelte';
export { default as WunderkindAd } from './components/AdSlot/WunderkindAd.svelte';

// Utilities
export { getEndNotesPropsFromDoc } from './components/EndNotes/docProps.js';
Expand Down