use native Go HTTP/2 server setup and graceful shutdown #59
+25
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace manual HTTP/2 connection handling with native HTTP server setup using HTTP/2 protocols. This change simplifies the server code and provides better shutdown handling through a proper server.Shutdown call. Also updates Go version to 1.24. The old implementation had a bug where once you start server you can't shut it down, even when context cancels, so it hand the client code, indefinitely.
this part of the code is redudant
khatibomar
commented
Mar 8, 2025
server/restate.go
Outdated
| return fmt.Errorf("failed to accept connection: %w", err) | ||
| go func() { | ||
| <-ctx.Done() | ||
| if err := server.Shutdown(context.Background()); err != nil { |
There was a problem hiding this comment.
here, I am not sure if doing a timeout of 30 seconds for example is better than leaving it trying to shutdown for ever.
There was a problem hiding this comment.
shutdownCtx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
defer cancel()
if err := server.Shutdown(shutdownCtx); err != nil {
slog.Error("Server shutdown error", "error", err)
}Add a 30 second timeout to the server shutdown context to prevent hanging indefinitely during shutdown. This ensures the server shuts down gracefully within a reasonable time frame.
errChan := make(chan error, 1)
go func(ctx context.Context) {
for {
con, err := listener.Accept()
if err != nil {
errChan <- fmt.Errorf("failed to accept connection: %w", err)
return
}
go h2server.ServeConn(con, opts)
}
}(ctx)
select {
case err := <-errChan:
return err
case <-ctx.Done():
return listener.Close()
}we can do that also for the old code, I think that connections will stay open because we are not doing con.Close(), so if the Start caller didn't wait on them and processed killed they will get force closed. So not really graceful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace manual HTTP/2 connection handling with native HTTP server setup using HTTP/2 protocols. This change simplifies the server code and provides better shutdown handling through a proper server.Shutdown call. Also updates Go version to 1.24.
The old implementation had a bug where once you start server you can't shut it down, even when context cancels, so it hangs the client code, indefinitely.