Migrate to System.Text.Json

[ColinTimBarndt]

Resolves #22

Notable changes:

• Using converter factories for generic types (enums, Resonite primitives)
  • No reflection is used for the Coder<T> type anymore
• enums have 2 generic converters: for regular enum types and for optional enums
• ConfigurationConverter for reading and writing config files
• ConfigurationConverter uses a thread local "context" to know what mod's config it's reading or writing
  • This was needed because System.Text.Json is a streaming API, which means that we can't just deserialize everything into a JObject and then parse it further once the version is read. With the streaming API, the config converter first reads the version field (which must come first, which it does) and then decides how to read the remaining JSON.
  • Advantage is that parsing configs should be much faster (though this has never been a problem for me)
• Since System.Text.Json is a streaming API, the version property is expected to come before the values property. Since this is already the case, this additional requirement shouldn't cause any problems.

The general structure is there, but further polishing is needed.

[ColinTimBarndt]

Needs testing, but otherwise feature complete

[XDelta]

Called twice?

[ColinTimBarndt]

I don't understand what you're referring to

[ColinTimBarndt]

Oh if you're referring to ending the object twice, it's because:

{
  "version": "...",
  "values": {
    //...
  } // first
} // second

[ColinTimBarndt]

@XDelta is there anything left blocking this PR?

[XDelta]

Pretty much just testing for breakage and what gets changed from older configs

[ColinTimBarndt]

I'll double check but I think I've been daily driving this custom build for some time now. Would need broader testing with other mods probably to be extra sure. Though this would break mods that implement custom serializers for Newtonsoft.Json.

[XDelta]

In some initial testing, there are a few that seem to not be saving or being able to use their config. CherryTypes, ModSettings, SpecialItemsLib showed some issues in my local copy.

[ColinTimBarndt]

CherryTypes is using a custom Newtonsoft.Json serializer and needs to be updated, I would expect issues to arise there.

[ColinTimBarndt]

While updating CherryTyes, I found a potential issue. By default, System.Text.Json only considers public properties and not fields. We could either enable IncludeFields = true in the JsonSerializerOptions or let mod authors update their mod by either using properties instead of public fields. I'd prefer the latter because public fields are not idiomatic.

[ColinTimBarndt]

What errors were you getting with ModSettings? (are we using the same mod?)
I specifically tested these mods with no issues by changing config values:

• CherryTypes (latest commit with fixes)
• ResoniteModSettings
• ResoniteIKCulling (has optional enum)
• CherryPick
• Restrainite
• ShowDelegates

[XDelta]

Im not at home but I think it was trying to do System.Type, and one other was some ValueTuple or Dict. Mainly trying to check as many as I can to address breakages where possible so that affected mods can have issues/prs created.

[ColinTimBarndt]

Here's a table showing the breakages that may arise from the migration:
https://learn.microsoft.com/en-us/dotnet/standard/serialization/system-text-json/migrate-from-newtonsoft?pivots=dotnet-10-0
System.Text.Json by design does not support "Type" to be deserialized. For stable serialization, I've made implemented my own serializer for CherryTypes since the result of ToString may change between versions of the runtime.