fix: make HTTP mode safer by default (localhost bind + origin checks + clear auth errors)#77
Open
Shubhdeep12 wants to merge 2 commits intoresend:mainfrom
Open
fix: make HTTP mode safer by default (localhost bind + origin checks + clear auth errors)#77Shubhdeep12 wants to merge 2 commits intoresend:mainfrom
Shubhdeep12 wants to merge 2 commits intoresend:mainfrom
Conversation
- Added configuration options for HTTP bind host and comma-separated origin allowlist. - Updated README to reflect new options and usage examples. - Modified server initialization to handle new parameters for host and allowed origins. - Implemented CORS handling to enforce origin restrictions on requests. - Enhanced error handling for unauthorized and forbidden requests.
- Removed redundant isString function and replaced it with a type guard in the allowed origins normalization process. - Enhanced type safety by ensuring only non-null strings are included in the allowed origins set.
Contributor
Author
|
i think its nice to have this check, wdyt @drish ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes: