Specialized errors for when colon and equals are mixed up #7900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
There was a problem hiding this comment.
Pull Request Overview
This PR adds specialized error messages for syntax errors where colons (:) and equals (=) are mixed up in various ReScript language constructs. The changes improve developer experience by providing clearer, context-specific error messages when these common syntax mistakes occur.
- Adds dedicated error messages for record field, pattern, and labelled argument syntax errors
- Implements error handling logic in the parser to detect and report these specific mistakes
- Provides comprehensive test coverage for all error scenarios
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| res_core.ml | Adds error message constants and parser logic to detect colon/equals mix-ups |
| recordFieldWrongAssignment.res (multiple) | Test cases demonstrating the syntax errors in different contexts |
| expected/*.res.txt (multiple) | Expected error output showing the new specialized error messages |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tests/syntax_tests/data/parsing/errors/structure/expected/recordFieldWrongAssignment.res.txt
Show resolved
Hide resolved
tests/syntax_tests/data/parsing/errors/pattern/expected/recordFieldWrongAssignment.res.txt
Show resolved
Hide resolved
...s/syntax_tests/data/parsing/errors/expressions/expected/labelledArgumentMissingEqual.res.txt
Show resolved
Hide resolved
nojaf
approved these changes
Sep 18, 2025
… function arguments, and more
zth
force-pushed
the
better-assign-errors
branch
from
09c1615 to
d9295b6
Compare
|
@cknitt care to have a look at these error messages? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good to have dedicated errors for these cases, where
:and=are mixed up.