Clean up string processing: delimiters

[cknitt]

First step in cleaning up string processing in the compiler. Define a unified String_kind.t as follows (replacing the existing delim type), make it mandatory and use it throughout the compiler pipeline (with the exception of the Parsetree for now).

    type t =
      | Standard (* Normal JS string with escaping *)
      | Verbatim (* Literal quoted string for tags *)
      | RawJs (* Raw JavaScript expressions *)
      | Template (* Template literals *)

[pkg-pr-new]

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7852

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7852

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7852

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7852

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7852

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@7852

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7852

commit: 7379d01

[cristianoc]

@codex review this change and explain the use of the various kinds of strings.
Is this just a refactor or could it change anything observable?
Make comments about style, clarity and possible simplifications.

[chatgpt-codex-connector]

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

[cknitt]

@cristianoc For now it should be just a refactor that shouldn't change any behavior.
I left out the Parsetree on purpose here as that's where things started breaking. 🙂
Can continue there later in a separate PR.

[tsnobip]

The current naming (DStarJ and such) is pretty bad, but I'm not a big fan of Standard and Verbatim, Verbatim is a double quoted string right? First time I hear about verbatim for strings but might be more common in other languages. But what about standard, what does it mean?

[cknitt]

I'll revisit this next week. Maybe I'll split the PR into two to separate the renaming from the other changes, and maybe we want to choose different names.