WIP - Extra app data #7387
WIP - Extra app data #7387
Conversation
| @@ -199,12 +199,13 @@ let expr sub x = | |||
| | Texp_function {arg_label; arity; param; case; partial; async} -> | |||
| Texp_function | |||
| {arg_label; arity; param; case = sub.case sub case; partial; async} | |||
| | Texp_apply {funct = exp; args = list; partial} -> | |||
| | Texp_apply {funct = exp; args = list; partial; transformed_jsx} -> | |||
There was a problem hiding this comment.
Store the potentially transformed jsx node.
| @@ -1277,7 +1278,7 @@ let mk_react_jsx (config : Jsx_common.jsx_config) mapper loc attrs | |||
| [key_prop; (nolabel, unit_expr ~loc:Location.none)] ) | |||
| in | |||
| let args = [(nolabel, elementTag); (nolabel, props_record)] @ key_and_unit in | |||
| Exp.apply ~loc ~attrs jsx_expr args | |||
| Exp.apply ~loc ~attrs ~transformed_jsx jsx_expr args | |||
| @@ -2401,7 +2401,7 @@ and type_expect_ ?type_clash_context ?in_function ?(recarg = Rejected) env sexp | |||
| type_function ?in_function ~arity ~async loc sexp.pexp_attributes env | |||
| ty_expected l | |||
| [Ast_helper.Exp.case spat sbody] | |||
| | Pexp_apply {funct = sfunct; args = sargs; partial} -> | |||
| | Pexp_apply {funct = sfunct; args = sargs; partial; transformed_jsx} -> | |||
There was a problem hiding this comment.
From here on, pass it along to the next layer.
There was a problem hiding this comment.
Looks like it never makes it here. So it must have gotten lost somewhere.
I'd start with a simple test examples and start adding some assert false whenever transformed_jsx is not None, to catch where was the last point where it was present before getting lost.
There was a problem hiding this comment.
Oh looks like it gets lost in bs_ast_mapper.
There was a problem hiding this comment.
Yeah, it seems to take a different route because <div> is an FFI call.
compiler/core/js_dump.ml
Outdated
| @@ -524,6 +524,10 @@ and expression_desc cxt ~(level : int) f x : cxt = | |||
| when Ext_list.length_equal el i | |||
| ]} | |||
| *) | |||
| | Call (e, el, {call_transformed_jsx = Some jsx_element}) -> | |||
There was a problem hiding this comment.
Hope it ends up here and do something meaningful.
Unfortunately, it didn't work for me. It got lost somewhere.
|
Got an initial result here, was able to transform: module ReactDOM = {
@module("react/jsx-runtime")
external jsx: (string, JsxDOM.domProps) => Jsx.element = "jsx"
}
let _ = <div className="meh"></div>into // Generated by ReScript, PLEASE EDIT WITH CARE
'use strict';
let JsxRuntime = require("react/jsx-runtime");
let ReactDOM = {};
<div className={"meh"}></div>;
exports.ReactDOM = ReactDOM;There are still a lot of cases to cover, but it is a start. |
@cristianoc, this doesn't work yet, but it highlights the idea. Could you point out where the information is not passed? It's a bit overwhelming for me to grasp.