Skip to content

Enable dynamic scenario naming #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
radekvonboktor wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Enable dynamic scenario naming #150

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b9bcf9
Enable dynamic scenario naming
radekvonboktor Sep 5, 2023
0cc70b5
fix to a mistake
radekvonboktor Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/api/current.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ module.exports = {
if (!this.isScenarioBasedStatistics) return;
}

const { name: scenarioName } = scenario;
const scenarioName = this.storage.getPickle(pickleId).name;
Copy link
Contributor

@Bam6ycha Bam6ycha Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@radekvonboktor Hi, there!
gherkin creates ast.
And every AST node such as pickle in our case, associates with the scenario through ASTNodeID
I mean, that pickle and scenario are almost the same entities.
Screenshot 2023-09-27 at 12 18 04

And as I can see, dynamic scenario naming already works fine.
Maybe I missed something. Could you please provide an example, where the scenario naming does not contain the value of the variable?

const [keyword] = scenario.keyword.split(' ');

const currentNodeCodeRef = utils.formatCodeRef(
Expand Down