Skip to content

fix(mcp): avoid task-group teardown abort in runTransport retry backoff #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pnascimento9596 wants to merge 1 commit into
base: main
Choose a base branch
from
+366 −30
Open

fix(mcp): avoid task-group teardown abort in runTransport retry backoff #517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Scripts/Fixtures/test-suite-contract-ledger.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,7 @@ root/RepoPromptTests.AgentModeViewModelInactiveRefreshTests/testActivationRepubl
root/RepoPromptTests.AgentModeViewModelInactiveRefreshTests/testActiveCodexAssistantDeltaUsesPresentationOnlyRefresh root Tests/RepoPromptTests/AgentMode/AgentModeViewModelInactiveRefreshTests.swift RepoPromptTests.AgentModeViewModelInactiveRefreshTests testActiveCodexAssistantDeltaUsesPresentationOnlyRefresh AgentMode unreviewed unreviewed root_swiftpm routine 1 unreviewed unreviewed 0.005000 unreviewed retain_pending_review 0 initial census source line 376
root/RepoPromptTests.AgentModeViewModelInactiveRefreshTests/testActiveGenericAssistantDeltaPublishesTranscriptWithoutFullBindingSync root Tests/RepoPromptTests/AgentMode/AgentModeViewModelInactiveRefreshTests.swift RepoPromptTests.AgentModeViewModelInactiveRefreshTests testActiveGenericAssistantDeltaPublishesTranscriptWithoutFullBindingSync AgentMode unreviewed unreviewed root_swiftpm routine 1 unreviewed unreviewed 0.003000 unreviewed retain_pending_review 0 initial census source line 349
root/RepoPromptTests.AgentModeViewModelInactiveRefreshTests/testActiveRefreshCompactsSummaryOnlyToolResultSourceWhilePreservingRawRenderPayload root Tests/RepoPromptTests/AgentMode/AgentModeViewModelInactiveRefreshTests.swift RepoPromptTests.AgentModeViewModelInactiveRefreshTests testActiveRefreshCompactsSummaryOnlyToolResultSourceWhilePreservingRawRenderPayload AgentMode unreviewed unreviewed root_swiftpm routine 1 unreviewed unreviewed 0.003000 unreviewed retain_pending_review 0 initial census source line 7
root/RepoPromptTests.AgentModeViewModelInactiveRefreshTests/testRetainedPayloadRefreshChangesOnlyMatchingResultRenderIdentity root Tests/RepoPromptTests/AgentMode/AgentModeViewModelInactiveRefreshTests.swift RepoPromptTests.AgentModeViewModelInactiveRefreshTests testRetainedPayloadRefreshChangesOnlyMatchingResultRenderIdentity AgentMode agent.transcript.raw_payload_item_identity tool_result,render_revision,item_identity,payload_retention deterministic_regression root_swiftpm routine 1 Refreshing one retained raw tool-result payload changes only that item's render revision and payload while leaving the sibling result unchanged. A tool-result refresh could invalidate or display another result's raw payload when multiple results share a transcript. 0.003000 test_case retain 0 Current-main ledger reconciliation for commit 1d783011.
root/RepoPromptTests.AgentModeViewModelInactiveRefreshTests/testAmbiguousPersistentBindingFailsRoutingWithoutLeakingCandidates root Tests/RepoPromptTests/AgentMode/AgentModeViewModelInactiveRefreshTests.swift RepoPromptTests.AgentModeViewModelInactiveRefreshTests testAmbiguousPersistentBindingFailsRoutingWithoutLeakingCandidates AgentMode unreviewed unreviewed root_swiftpm routine 1 unreviewed unreviewed 0.001500 unreviewed retain_pending_review 0 initial census source line 597
root/RepoPromptTests.AgentModeViewModelInactiveRefreshTests/testAssistantPresentationRejectsStaleRevisionGenerationAndTabOwnership root Tests/RepoPromptTests/AgentMode/AgentModeViewModelInactiveRefreshTests.swift RepoPromptTests.AgentModeViewModelInactiveRefreshTests testAssistantPresentationRejectsStaleRevisionGenerationAndTabOwnership AgentMode unreviewed unreviewed root_swiftpm routine 1 unreviewed unreviewed 0.003000 unreviewed retain_pending_review 0 initial census source line 425
root/RepoPromptTests.AgentModeViewModelInactiveRefreshTests/testAssistantPresentationRequiresAuthoritativeHydratedBindingGeneration root Tests/RepoPromptTests/AgentMode/AgentModeViewModelInactiveRefreshTests.swift RepoPromptTests.AgentModeViewModelInactiveRefreshTests testAssistantPresentationRequiresAuthoritativeHydratedBindingGeneration AgentMode unreviewed unreviewed root_swiftpm routine 1 unreviewed unreviewed 0.004000 unreviewed retain_pending_review 0 initial census source line 473
Expand Down Expand Up @@ -1835,6 +1836,9 @@ root/RepoPromptTests.MCPProxyTerminalRecordTests/testLocalSocketReadFailureIsAtt
root/RepoPromptTests.MCPProxyTerminalRecordTests/testProxyTaskGroupOutcomesClassifyCleanCompletionAndCancellation root Tests/RepoPromptTests/MCP/MCPProxyTerminalRecordTests.swift RepoPromptTests.MCPProxyTerminalRecordTests testProxyTaskGroupOutcomesClassifyCleanCompletionAndCancellation MCP mcp.proxy.task_group_outcome_classification proxy,cancellation,outcome_classification deterministic_regression root_swiftpm routine 1 MCPServiceProxyTaskGroupPolicy Clean transport completion stays clean while watcher and service cancellation outcomes normalize to host task-cancelled provenance. A canceled proxy could persist a false clean terminal record and hide lifecycle failures. 0.000000 test_case retain 0 PR #252 final proxy cancellation cleanup
root/RepoPromptTests.MCPProxyTerminalRecordTests/testSocketReadFailureRemainsRetryablePeerTransportFailure root Tests/RepoPromptTests/MCP/MCPProxyTerminalRecordTests.swift RepoPromptTests.MCPProxyTerminalRecordTests testSocketReadFailureRemainsRetryablePeerTransportFailure MCP unreviewed unreviewed root_swiftpm routine 1 unreviewed unreviewed 0.000000 unreviewed retain_pending_review 0 initial census source line 60
root/RepoPromptTests.MCPProxyTerminalRecordTests/testTerminalRecordCopiesLiveLedgerSnapshotAndServerReason root Tests/RepoPromptTests/MCP/MCPProxyTerminalRecordTests.swift RepoPromptTests.MCPProxyTerminalRecordTests testTerminalRecordCopiesLiveLedgerSnapshotAndServerReason MCP unreviewed unreviewed root_swiftpm routine 1 unreviewed unreviewed 0.000000 unreviewed retain_pending_review 0 initial census source line 128
root/RepoPromptTests.MCPServiceProxyRaceTests/testEachChildCanWinWithValueOrErrorAndDrainsLosers root Tests/RepoPromptTests/MCP/MCPServiceProxyRaceTests.swift RepoPromptTests.MCPServiceProxyRaceTests testEachChildCanWinWithValueOrErrorAndDrainsLosers MCP mcp.proxy.first_completion_priority proxy,cancellation,error_priority,task_drain deterministic_regression root_swiftpm fast 6 Each of the three proxy operations can win with its value or error, and both losing operations observe cancellation and complete before the race returns. Changing completion priority or failing to drain a suspended loser could misclassify terminal state or reintroduce the Swift release-runtime teardown abort. 0.001000 test_case retain 0 Issue #513 explicit-task first-completion race coverage.
root/RepoPromptTests.MCPServiceProxyRaceTests/testOuterCancellationCancelsAndDrainsAllChildren root Tests/RepoPromptTests/MCP/MCPServiceProxyRaceTests.swift RepoPromptTests.MCPServiceProxyRaceTests testOuterCancellationCancelsAndDrainsAllChildren MCP mcp.proxy.outer_cancellation_drain proxy,cancellation,task_drain deterministic_regression root_swiftpm fast 1 Caller cancellation reaches all three proxy operations, surfaces as CancellationError, and waits for every operation to complete before returning. Outer cancellation could leak or tear down a suspended proxy operation and persist incorrect terminal provenance. 0.001000 test_case retain 0 Issue #513 cancellation-handler teardown coverage.
root/RepoPromptTests.MCPServiceProxyRaceTests/testRaceDoesNotReturnUntilCancelledLosersComplete root Tests/RepoPromptTests/MCP/MCPServiceProxyRaceTests.swift RepoPromptTests.MCPServiceProxyRaceTests testRaceDoesNotReturnUntilCancelledLosersComplete MCP mcp.proxy.loser_completion_barrier proxy,cancellation,task_drain deterministic_regression root_swiftpm fast 1 A controlled loser-completion gate proves the proxy race remains suspended after cancellation until both losing operations finish. Returning after cancel without awaiting loser completion recreates the compiler-frame teardown shape implicated in swift_task_dealloc aborts. 0.001000 test_case retain 0 Issue #513 structural regression oracle; fails against cancel-without-await.
root/RepoPromptTests.MCPReadFileAutoSelectionCoordinatorTests/testAuthoritativeSelectionPreservationRequiresFullCanonicalSuperset root Tests/RepoPromptTests/MCP/MCPReadFileAutoSelectionCoordinatorTests.swift RepoPromptTests.MCPReadFileAutoSelectionCoordinatorTests testAuthoritativeSelectionPreservationRequiresFullCanonicalSuperset MCP mcp.read_file.auto_selection.authoritative_selection_preservation exact,additive_superset,full_supersedes_slice,selected_path_loss,full_to_slice_demotion,auto_codemap_loss,slice_narrowing,codemap_mode_change deterministic_table_unit root_swiftpm routine 8 stored_selection Certificate mint revalidation accepts only a full canonical superset of the authoritative result across selected paths, auto-codemap paths, slices, and codemap mode. critical 0.000000 in_memory per_test_state retain 0 read-file selection rebasing full-state preservation guard
root/RepoPromptTests.MCPReadFileAutoSelectionCoordinatorTests/testCancelledCanonicalDrainResumesPromptlyWithoutStoppingWorker root Tests/RepoPromptTests/MCP/MCPReadFileAutoSelectionCoordinatorTests.swift RepoPromptTests.MCPReadFileAutoSelectionCoordinatorTests testCancelledCanonicalDrainResumesPromptlyWithoutStoppingWorker MCP unreviewed unreviewed root_swiftpm routine 1 unreviewed unreviewed 0.004500 unreviewed retain_pending_review 0 initial census source line 141
root/RepoPromptTests.MCPReadFileAutoSelectionCoordinatorTests/testCancelledMirrorDrainResumesPromptlyWithoutStoppingWorker root Tests/RepoPromptTests/MCP/MCPReadFileAutoSelectionCoordinatorTests.swift RepoPromptTests.MCPReadFileAutoSelectionCoordinatorTests testCancelledMirrorDrainResumesPromptlyWithoutStoppingWorker MCP unreviewed unreviewed root_swiftpm routine 1 unreviewed unreviewed 0.004500 unreviewed retain_pending_review 0 initial census source line 175
Expand Down Expand Up @@ -2250,6 +2254,8 @@ root/RepoPromptTests.SettingsJSONOnlyPersistenceTests/testMissingGlobalSettingsC
root/RepoPromptTests.SettingsJSONOnlyPersistenceTests/testObsoleteGitignoreJSONKeyIsIgnoredAndNeverEmitted root Tests/RepoPromptTests/SettingsJSONOnlyPersistenceTests.swift RepoPromptTests.SettingsJSONOnlyPersistenceTests testObsoleteGitignoreJSONKeyIsIgnoredAndNeverEmitted Root unreviewed unreviewed root_swiftpm routine 1 unreviewed unreviewed 0.001000 unreviewed retain_pending_review 0 initial census source line 32
root/RepoPromptTests.SettingsJSONOnlyPersistenceTests/testSentryScrubStringRedactsAuthorizationSchemesAndCredentialTails root Tests/RepoPromptTests/SettingsJSONOnlyPersistenceTests.swift RepoPromptTests.SettingsJSONOnlyPersistenceTests testSentryScrubStringRedactsAuthorizationSchemesAndCredentialTails Root telemetry.sentry_scrub.authorization_and_credential_tail_redaction sentry,privacy,authorization,bearer,basic,api_key privacy_redaction_unit root_swiftpm routine 6 Sentry scrubbing redacts Bearer and Basic authorization headers, lowercase authorization assignments, bare Bearer credential tails, X-Api-Key values, and preserves benign text. Telemetry breadcrumbs could leak authorization credentials or over-redact harmless prose. test_case retain 0 origin/main reconciliation after commits 5c1504f1/dc79e7a4: reviewed Sentry authorization-scheme redaction coverage.
root/RepoPromptTests.SettingsJSONOnlyPersistenceTests/testSentryScrubStringRedactsSensitiveValues root Tests/RepoPromptTests/SettingsJSONOnlyPersistenceTests.swift RepoPromptTests.SettingsJSONOnlyPersistenceTests testSentryScrubStringRedactsSensitiveValues Root telemetry.sentry_scrub.sensitive_value_redaction sentry,privacy,token,password,user_path,ip_address privacy_redaction_unit root_swiftpm routine 4 Sentry scrubbing redacts token values, password values, the current user home path, and private IP addresses while preserving redaction markers. Telemetry payloads could expose local secrets, usernames, or network identifiers. test_case retain 0 origin/main reconciliation after commits 5c1504f1/dc79e7a4: reviewed Sentry sensitive-value redaction coverage.
root/RepoPromptTests.SettingsJSONOnlyPersistenceTests/testSentryScrubPayloadDropsNestedRequestAndGeoFieldsWithoutDroppingSafeSiblings root Tests/RepoPromptTests/SettingsJSONOnlyPersistenceTests.swift RepoPromptTests.SettingsJSONOnlyPersistenceTests testSentryScrubPayloadDropsNestedRequestAndGeoFieldsWithoutDroppingSafeSiblings Root telemetry.sentry_scrub.nested_sensitive_keys sentry,privacy,nested_payload,request,geo privacy_redaction_unit root_swiftpm routine 1 Recursive Sentry payload scrubbing drops nested URL, query-string, and user-geo fields while preserving safe sibling values. Nested telemetry dictionaries could leak request or location data, or privacy filtering could discard unrelated diagnostic fields. 0.001000 test_case retain 0 Current-main ledger reconciliation for commit 296f6787.
root/RepoPromptTests.SettingsJSONOnlyPersistenceTests/testSentryScrubPayloadDropsRequestGeoUserAndStableDeviceIdentifiers root Tests/RepoPromptTests/SettingsJSONOnlyPersistenceTests.swift RepoPromptTests.SettingsJSONOnlyPersistenceTests testSentryScrubPayloadDropsRequestGeoUserAndStableDeviceIdentifiers Root telemetry.sentry_scrub.identity_and_request_fields sentry,privacy,request,user,device_identifier privacy_redaction_unit root_swiftpm routine 1 Sentry payload scrubbing removes request, user, geo, installation, and stable device identifiers while preserving safe OS, model, app, and redacted-note fields. Telemetry events could expose stable user or device identity and request data, or over-redaction could remove safe operational context. 0.001000 test_case retain 0 Current-main ledger reconciliation for commit 296f6787.
root/RepoPromptTests.SettingsJSONOnlyPersistenceTests/testShowDatesInMessageTimestampsDefaultsFalseWithoutPersisting root Tests/RepoPromptTests/SettingsJSONOnlyPersistenceTests.swift RepoPromptTests.SettingsJSONOnlyPersistenceTests testShowDatesInMessageTimestampsDefaultsFalseWithoutPersisting Settings settings.message_timestamp_dates.default_migration optional_json_field,default_false,no_read_time_persist deterministic_persistence root_swiftpm routine 1 temporary_settings_file,isolated_user_defaults A missing optional field reads false while the persisted JSON remains byte-for-byte unchanged. medium 0.001000 temporary_directory,filesystem,user_defaults method_local_values+defer retain 0 backward-compatible default contract
root/RepoPromptTests.SettingsJSONOnlyPersistenceTests/testShowDatesInMessageTimestampsSavesAndLoadsTrue root Tests/RepoPromptTests/SettingsJSONOnlyPersistenceTests.swift RepoPromptTests.SettingsJSONOnlyPersistenceTests testShowDatesInMessageTimestampsSavesAndLoadsTrue Settings settings.message_timestamp_dates.round_trip json_round_trip,reload deterministic_persistence root_swiftpm routine 1 temporary_settings_file,isolated_user_defaults Enabling date context persists true and a newly initialized store reloads true. medium 0.001500 temporary_directory,filesystem,user_defaults method_local_values+defer retain 0 settings round-trip contract
root/RepoPromptTests.SettingsJSONOnlyPersistenceTests/testTelemetryJSONValueOverridesStaleEnabledMirror root Tests/RepoPromptTests/SettingsJSONOnlyPersistenceTests.swift RepoPromptTests.SettingsJSONOnlyPersistenceTests testTelemetryJSONValueOverridesStaleEnabledMirror Root settings.telemetry.json_overrides_stale_enabled_mirror settings_json,telemetry,user_defaults_mirror persistence_regression root_swiftpm routine 1 temporary_settings_file,UserDefaults(suiteName:) A persisted telemetry JSON value of false overrides a stale legacy defaults mirror of true and rewrites the mirror to false. Legacy defaults could override the canonical JSON telemetry value. filesystem isolated_user_defaults test_case retain 0 origin/main reconciliation after commits 5c1504f1/dc79e7a4: reviewed telemetry JSON-over-mirror precedence coverage.
Expand Down
Loading
Loading