Fix app hang during date formatting by pre-warming locale cache#438
Open
sentry[bot] wants to merge 1 commit into
Open
Fix app hang during date formatting by pre-warming locale cache#438sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an app hanging issue (REPOPROMPT-8) where the application would freeze for 2000ms+ on macOS 26.x.
Root Cause:
The hang was traced to synchronous, expensive ICU (International Components for Unicode) locale processing occurring on the main thread. Specifically, the
MessageTimestampFormatter'ssetLocalizedDateFormatFromTemplate(_:)call, triggered during SwiftUI rendering, would block the main thread while inferring locale subtags (ulocimp_addLikelySubtags->RegionValidateMap::equals->res_getTableItemByKey). This was particularly noticeable on macOS 26.x, suggesting changes in ICU data loading behavior.Solution:
To prevent this main thread blockage, the
MessageTimestampFormatter's cache is now pre-warmed on a background thread during application startup. This ensures that when the main thread first requests a formatted timestamp, the expensiveDateFormatterandRelativeDateTimeFormatterinstances, along with their underlying ICU data, have already been initialized and cached.Changes Made:
warmUp()static method toMessageTimestampFormatterto explicitly pre-populate its internalDateFormatterandRelativeDateTimeFormattercaches for all commonly used formats and templates.MessageTimestampFormatter.warmUp()within aTask.detached(priority: .utility)inRepoPromptApp.init(). This executes the pre-warming on a background thread, preventing UI freezes.The existing
NSLockinMessageTimestampFormatterCacheensures thread-safe access during concurrent initialization and subsequent main-thread usage.Fixes REPOPROMPT-8