Skip to content

Stabilize AgentRunWorktreeStartTests production-capture selection race (#420) #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
moonray wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −4
Open

Stabilize AgentRunWorktreeStartTests production-capture selection race (#420) #430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions Tests/RepoPromptTests/MCP/AgentRunWorktreeStartTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,10 +909,20 @@ final class AgentRunWorktreeStartTests: AgentRunWorktreeStartGitSeedTestCase {
sourceAgentSessionID: parentSessionID,
routedRunID: nil
)
let source = await window.mcpServer.testCaptureAgentRunOracleReviewSource(
snapshot: launchSnapshot,
targetWindow: window
)
// The capture's drift guard re-validates the canonical selection after its async work. This
// test deliberately keeps the active UI selection diverged from canonical so it can prove
// capture serves the *stored* selection rather than the UI. A debounced token recount can
// otherwise flush that divergent UI selection back into canonical during the capture's await
// window and falsely trip the guard ("launching selection changed ..."). Hold the selection
// mirror's flush suppression across the capture — the same suppression production applies
// during sensitive selection operations — so canonical stays stable while the frozen review
// capability is built.
let source = await window.selectionCoordinator.withApplyingSelectionMirror {
await window.mcpServer.testCaptureAgentRunOracleReviewSource(
snapshot: launchSnapshot,
targetWindow: window
)
}
guard case let .captured(captured) = source else {
if case let .unavailable(unavailable) = source {
return XCTFail(
Expand Down
Loading