Skip to content

Speed up dev-lint SwiftLint discovery#428

Merged
baron merged 2 commits into
mainfrom
wt/issue-426-dev-lint-swiftlint
Jul 8, 2026
Merged

Speed up dev-lint SwiftLint discovery#428
baron merged 2 commits into
mainfrom
wt/issue-426-dev-lint-swiftlint

Conversation

@baron

@baron baron commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Switch full-repo Scripts/swift_style.sh lint to config-discovered SwiftLint with --quiet --force-exclude, avoiding SCRIPT_INPUT_FILE_* overhead.
  • Align .swiftlint.yml include/exclude scope with the wrapper's first-party Swift style scope, including generated/vendor/build/transient paths and large workflow prompt files.
  • Add a regression test to guard against reintroducing script-input mode and to keep SwiftLint config includes aligned with STYLE_PATHS.

Closes #426.

Validation

  • python3 -m unittest Scripts.test_release_tooling.ReleaseToolingTests.test_swift_style_lint_uses_config_discovery_without_script_input_overhead
  • bash -n Scripts/swift_style.sh
  • /usr/bin/time -p make dev-lint
    • Post-rebase conductor ticket: a695917e-ff5f-43a8-b9b6-57b68d284c14
    • Passed; SwiftLint command shown as swiftlint lint --strict --config .../.swiftlint.yml --quiet --force-exclude
  • .agents/skills/rpce-contribution-check/scripts/preflight.sh commit
  • .agents/skills/rpce-contribution-check/scripts/preflight.sh push

Review

  • Claude Fable 5 read-only review found no must-fix issues and concluded lint/formatting integrity is preserved.
  • Folded in its suggested test hardening for .swiftlint.yml included: parity with STYLE_PATHS.

Comment thread Scripts/test_release_tooling.py Outdated
@baron baron merged commit a89ab6c into main Jul 8, 2026
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Speed up dev-lint by avoiding SwiftLint script-input mode for full-repo lint

1 participant