Skip to content

Fix tab slice rebase retries with planned ranges #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
morluto wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix tab slice rebase retries with planned ranges #386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14bec13
fix(workspaces): make tab slice rebases planned
morluto Jul 6, 2026
c57c10a
test(workspaces): cover planned slice rebase races
morluto Jul 6, 2026
d0f20c5
test(agent-mode): stabilize oracle source capture fixture
morluto Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Scripts/Fixtures/test-suite-contract-ledger.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2023,7 +2023,7 @@ root/RepoPromptTests.PathMatchingRecoveryTests/testMovePathResolverRejectsAmbigu
root/RepoPromptTests.PathMatchingRecoveryTests/testUnicodeAndCaseInsensitiveLookupPreserveStoredRelativePath root Tests/RepoPromptTests/WorkspaceContext/PathMatching/PathMatchingRecoveryTests.swift RepoPromptTests.PathMatchingRecoveryTests testUnicodeAndCaseInsensitiveLookupPreserveStoredRelativePath WorkspaceContext unreviewed unreviewed root_swiftpm routine 1 unreviewed unreviewed 0.000000 unreviewed retain_pending_review 0 initial census source line 21
root/RepoPromptTests.PathSearchIndexRecoveryTests/testSearchMatchesFilenameSubpathTokensAndPublishesDeterministicRankMetadata root Tests/RepoPromptTests/WorkspaceContext/Search/PathSearchIndexRecoveryTests.swift RepoPromptTests.PathSearchIndexRecoveryTests testSearchMatchesFilenameSubpathTokensAndPublishesDeterministicRankMetadata WorkspaceContext unreviewed unreviewed root_swiftpm routine 1 unreviewed unreviewed 0.005000 unreviewed retain_pending_review 0 initial census source line 5
root/RepoPromptTests.PersistentAgentModeMCPReadFileConnectionTests/testAgentOwnedExplicitSetPersistsForIndependentCanonicalLookup root Tests/RepoPromptTests/MCP/Control/PersistentAgentModeMCPReadFileConnectionTests.swift RepoPromptTests.PersistentAgentModeMCPReadFileConnectionTests testAgentOwnedExplicitSetPersistsForIndependentCanonicalLookup MCP unreviewed unreviewed root_swiftpm routine 1 unreviewed unreviewed 0.541500 unreviewed retain_pending_review 0 initial census source line 28
root/RepoPromptTests.PersistentAgentModeMCPReadFileConnectionTests/testAgentOwnedHiddenWorktreeWatcherRebases6500LineReadSlicesBeforePostEditReads root Tests/RepoPromptTests/MCP/Control/PersistentAgentModeMCPReadFileConnectionTests.swift RepoPromptTests.PersistentAgentModeMCPReadFileConnectionTests testAgentOwnedHiddenWorktreeWatcherRebases6500LineReadSlicesBeforePostEditReads MCP mcp.hidden_session_worktree.read_slice_watcher_rebase persistent_agent,read_file,6500_lines,watcher_rebase,physical_logical_mapping,full_selection_dominance,no_hidden_ui_tree,stale_deferred_commit,partition_cas deterministic_integration root_swiftpm routine 5 PersistentAgentModeMCPConnectionFixture,SessionWorktreeOwnershipFixture,WorkspaceSelectionSliceFixture Three canonical read_file slices rebase exactly after atomic replacement; a gated successor cannot resurrect a concurrently removed logical target or physical partition entry; the hidden root never projects into UI and later reads cannot downgrade a full selection. critical 1.386500 socketpair,temporary_worktree,actor_store,watcher_publisher,async_tasks test_fixture+explicit_root_unload retain 0 hidden session-root watcher rebase, stale deferred partition/target fencing, and full-file-wins integration
root/RepoPromptTests.PersistentAgentModeMCPReadFileConnectionTests/testAgentOwnedHiddenWorktreeWatcherRebases6500LineReadSlicesBeforePostEditReads root Tests/RepoPromptTests/MCP/Control/PersistentAgentModeMCPReadFileConnectionTests.swift RepoPromptTests.PersistentAgentModeMCPReadFileConnectionTests testAgentOwnedHiddenWorktreeWatcherRebases6500LineReadSlicesBeforePostEditReads MCP mcp.hidden_session_worktree.read_slice_watcher_rebase persistent_agent,read_file,6500_lines,watcher_rebase,physical_logical_mapping,full_selection_dominance,no_hidden_ui_tree,stale_deferred_commit,partition_cas,post_cas_tab_plan_stale_target deterministic_integration root_swiftpm routine 6 PersistentAgentModeMCPConnectionFixture,SessionWorktreeOwnershipFixture,WorkspaceSelectionSliceFixture Three canonical read_file slices rebase exactly after atomic replacement; a post-CAS stale hidden target cannot apply an already-built tab plan; a gated successor cannot resurrect a concurrently removed logical target or physical partition entry; the hidden root never projects into UI and later reads cannot downgrade a full selection. critical 1.386500 socketpair,temporary_worktree,actor_store,watcher_publisher,async_tasks test_fixture+explicit_root_unload retain 1 expanded hidden session-root watcher rebase coverage for post-CAS stale tab-plan filtering, stale deferred partition/target fencing, and full-file-wins integration
root/RepoPromptTests.PersistentAgentModeMCPReadFileConnectionTests/testAgentOwnedWorktreeContentSearchCarriesPhysicalCoverageAndPreservesFullSelections root Tests/RepoPromptTests/MCP/Control/PersistentAgentModeMCPReadFileConnectionTests.swift RepoPromptTests.PersistentAgentModeMCPReadFileConnectionTests testAgentOwnedWorktreeContentSearchCarriesPhysicalCoverageAndPreservesFullSelections MCP mcp.hidden_session_worktree.search_context_watcher_rebase persistent_agent,file_search,context_lines,physical_coverage_identity,no_path_leak,watcher_rebase,full_selection_dominance deterministic_integration root_swiftpm routine 5 PersistentAgentModeMCPConnectionFixture,SessionWorktreeOwnershipFixture,WorkspaceSelectionSliceFixture Watcher-created worktree content is searchable without physical-path disclosure; context_lines=2 selects exact 2-6/13-17/25-29 logical slices, atomic replacement rebases them to 6-10/20-24/30-34, unrelated and matching full selections remain full. critical 0.821500 socketpair,temporary_worktree,actor_store,watcher_publisher,async_tasks test_fixture+explicit_session_owner_release retain 0 search physical coverage sidecar, hidden watcher rebase, and full-file-wins integration
root/RepoPromptTests.PersistentAgentModeMCPReadFileConnectionTests/testCodexAgentModeLeaseRetainsOneMCPServerSessionAcrossSerialExactAbsoluteReadFileCalls root Tests/RepoPromptTests/MCP/Control/PersistentAgentModeMCPReadFileConnectionTests.swift RepoPromptTests.PersistentAgentModeMCPReadFileConnectionTests testCodexAgentModeLeaseRetainsOneMCPServerSessionAcrossSerialExactAbsoluteReadFileCalls MCP unreviewed unreviewed root_swiftpm routine 1 unreviewed unreviewed unreviewed retain_pending_review 0 initial census source line 59
root/RepoPromptTests.PersistentAgentModeMCPReadFileConnectionTests/testManageSelectionGetStopsAtCanonicalHandoverWhileMirrorBlocked root Tests/RepoPromptTests/MCP/Control/PersistentAgentModeMCPReadFileConnectionTests.swift RepoPromptTests.PersistentAgentModeMCPReadFileConnectionTests testManageSelectionGetStopsAtCanonicalHandoverWhileMirrorBlocked MCP unreviewed unreviewed root_swiftpm routine 1 unreviewed unreviewed 0.333500 unreviewed retain_pending_review 0 initial census source line 49
Expand Down Expand Up @@ -2175,6 +2175,7 @@ root/RepoPromptTests.SelectionSlicePersistenceAndRebaseTests/testPartitionStoreC
root/RepoPromptTests.SelectionSlicePersistenceAndRebaseTests/testPartitionStoreCASIsSerializedAcrossStoreInstances root Tests/RepoPromptTests/WorkspaceContext/Slices/SelectionSlicePersistenceAndRebaseTests.swift RepoPromptTests.SelectionSlicePersistenceAndRebaseTests testPartitionStoreCASIsSerializedAcrossStoreInstances WorkspaceContext workspace.slice_partition.cross_instance_cas_serialization compare_and_swap,cross_instance_serialization deterministic_concurrency root_swiftpm routine 1 PartitionStoreCASGate Two store instances serialize compare-and-swap so only the first stale-baseline writer succeeds and its partition remains persisted. critical 0.058000 temporary_directory,filesystem,dispatch_semaphore process_partition_file_lock test_case+defer retain 0 Cross-window store instances share the same partition-file CAS boundary.
root/RepoPromptTests.SelectionSlicePersistenceAndRebaseTests/testPartitionStoreCancellationAfterAtomicWriteStillSucceedsAndNotifies root Tests/RepoPromptTests/WorkspaceContext/Slices/SelectionSlicePersistenceAndRebaseTests.swift RepoPromptTests.SelectionSlicePersistenceAndRebaseTests testPartitionStoreCancellationAfterAtomicWriteStillSucceedsAndNotifies WorkspaceContext workspace.slice_partition.post_commit_cancellation atomic_persistence,cancellation,notification deterministic_concurrency root_swiftpm routine 1 PartitionStorePersistGate Cancellation after the atomic write still returns the committed partition and posts the required change notification. critical 0.002500 temporary_directory,filesystem,notification_center,dispatch_semaphore notification_center test_case+defer retain 0 Post-commit cancellation must not turn durable success into reported failure.
root/RepoPromptTests.SelectionSlicePersistenceAndRebaseTests/testPartitionStoreColdReloadPreservesSlicesAndIsolatesScopes root Tests/RepoPromptTests/WorkspaceContext/Slices/SelectionSlicePersistenceAndRebaseTests.swift RepoPromptTests.SelectionSlicePersistenceAndRebaseTests testPartitionStoreColdReloadPreservesSlicesAndIsolatesScopes WorkspaceContext unreviewed unreviewed root_swiftpm routine 1 unreviewed unreviewed 0.002500 unreviewed retain_pending_review 0 initial census source line 5
root/RepoPromptTests.SelectionSlicePersistenceAndRebaseTests/testPlannedTabSliceRebaseIsIdempotentAndFailsClosed root Tests/RepoPromptTests/WorkspaceContext/Slices/SelectionSlicePersistenceAndRebaseTests.swift RepoPromptTests.SelectionSlicePersistenceAndRebaseTests testPlannedTabSliceRebaseIsIdempotentAndFailsClosed WorkspaceContext workspace.slice_rebase.planned_tab_contract expected_ranges,idempotent,fail_closed,tab_selection deterministic_regression root_swiftpm routine 3 Planned tab slice rebases apply only from expected ranges, no-op when already rebased, and leave independently changed ranges untouched. high 0.000500 method_local_values retain 0 Regression for coordinate-epoch ambiguous tab rebase retries.
root/RepoPromptTests.SelectionSlicePersistenceAndRebaseTests/testSliceRebaseDropsOnlyWhenPostEditContentHasNoValidLine root Tests/RepoPromptTests/WorkspaceContext/Slices/SelectionSlicePersistenceAndRebaseTests.swift RepoPromptTests.SelectionSlicePersistenceAndRebaseTests testSliceRebaseDropsOnlyWhenPostEditContentHasNoValidLine WorkspaceContext workspace.slice_rebase.empty_document_drop slice_selection,post_edit_bounds deterministic_regression root_swiftpm routine 1 An edit producing a zero-line document drops the prior range and reports a real change rather than stale input. medium 0.000000 method_local_values retain 0 renamed from root/RepoPromptTests.SelectionSlicePersistenceAndRebaseTests/testSliceRebaseDropsRangesForEmptyAndUnmappableContent; unmappable nonempty inputs now preserve slices through stale behavior
root/RepoPromptTests.SelectionSlicePersistenceAndRebaseTests/testSliceRebaseEqualCacheUsesSavedAnchorFallback root Tests/RepoPromptTests/WorkspaceContext/Slices/SelectionSlicePersistenceAndRebaseTests.swift RepoPromptTests.SelectionSlicePersistenceAndRebaseTests testSliceRebaseEqualCacheUsesSavedAnchorFallback WorkspaceContext workspace.slice_rebase.stale_snapshot_fallback anchors,stale_snapshot,no_empty_publication deterministic_regression root_swiftpm routine 5 Equal-cache anchors rebase correctly, while mismatched, unavailable, partial-anchor, or disjoint-anchor snapshots report stale and preserve existing ranges. high 0.001500 method_local_values retain 0 expanded in iteration 2 to cover mismatched and unavailable snapshot stale behavior
root/RepoPromptTests.SelectionSlicePersistenceAndRebaseTests/testSliceRebaseLargeBeginningMiddleEndEditsAndRestoresStayCanonical root Tests/RepoPromptTests/WorkspaceContext/Slices/SelectionSlicePersistenceAndRebaseTests.swift RepoPromptTests.SelectionSlicePersistenceAndRebaseTests testSliceRebaseLargeBeginningMiddleEndEditsAndRestoresStayCanonical WorkspaceContext workspace.slice_rebase.large_bme_restore large_file,bounds,restore deterministic_regression root_swiftpm routine 6 generated_14050_line_fixture Beginning, middle, and end edit plus restore mappings remain nonempty, ordered, in bounds, and return to exact original ranges. high 0.086500 generated_large_file method_local_values retain 0 iteration 2 generated fixture; three edits and three restores
Expand Down
Loading
Loading