Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added V4.1 fixes #175 #182

Merged
merged 3 commits into from
Dec 17, 2021
Merged

added V4.1 fixes #175 #182

merged 3 commits into from
Dec 17, 2021

Conversation

MarieLataretu
Copy link
Collaborator

fixes #175

I avoided a . in the folder's name, since it could have an effect, when simpleName is used.

If you prefer something else, let me know!

@hoelzer
Copy link
Collaborator

hoelzer commented Dec 16, 2021

but can I already select this primer scheme now, @MarieLataretu ? via --primerV V4-1 ?

And then we should likely also add the support of this kit to the --help

@hoelzer
Copy link
Collaborator

hoelzer commented Dec 16, 2021

just performing a testrun w/ this setting now (although the primer kit originally used was V4)

@hoelzer
Copy link
Collaborator

hoelzer commented Dec 16, 2021

besides, run through @MarieLataretu ! nice. If the first V4.1 sequencing pops up we can try this and if it works fine merge

@@ -466,12 +466,12 @@ ${c_yellow}Parameters - Basecalling (optional)${c_reset}

${c_yellow}Parameters - SARS-CoV-2 genome reconstruction (optional)${c_reset}
--primerV Supported primer variants - choose one [default: ${params.primerV}]
${c_dim}ARTIC:${c_reset} V1, V2, V3, V4
${c_dim}ARTIC:${c_reset} V1, V2, V3, V4, V4.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but here I have to use V4-1, or? as the parameter

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed it. I typed V4-1 and it was ugly...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D okay so now one can use --primerV V4.1 ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked - {params.primerV} is always used as it is

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, --primerV V4.1 should work :)

@MarieLataretu
Copy link
Collaborator Author

MarieLataretu commented Dec 17, 2021

I updated the readme and help - also with V4 :)


nextflow run poreCov.nf -profile singularity,local,test_fastq,stub --cores 2 --max_cores 2 --primerV V4.1

works fine, but I cheated with stub.

Edit: looks also fine without stub

@hoelzer
Copy link
Collaborator

hoelzer commented Dec 17, 2021

worked and looks good! amplicon recovered via V4.1 in omicron! I will merge, but once the ARTIC network puts the "offical" BED in their repository we might want to update again

thx!

@hoelzer hoelzer merged commit c53af98 into replikation:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARTIC V4.1 primer scheme for Omicron
2 participants