-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added V4.1 fixes #175 #182
Conversation
but can I already select this primer scheme now, @MarieLataretu ? via And then we should likely also add the support of this kit to the |
just performing a testrun w/ this setting now (although the primer kit originally used was V4) |
besides, run through @MarieLataretu ! nice. If the first V4.1 sequencing pops up we can try this and if it works fine merge |
@@ -466,12 +466,12 @@ ${c_yellow}Parameters - Basecalling (optional)${c_reset} | |||
|
|||
${c_yellow}Parameters - SARS-CoV-2 genome reconstruction (optional)${c_reset} | |||
--primerV Supported primer variants - choose one [default: ${params.primerV}] | |||
${c_dim}ARTIC:${c_reset} V1, V2, V3, V4 | |||
${c_dim}ARTIC:${c_reset} V1, V2, V3, V4, V4.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but here I have to use V4-1, or? as the parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed it. I typed V4-1 and it was ugly...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:D okay so now one can use --primerV V4.1
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked - {params.primerV}
is always used as it is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, --primerV V4.1
should work :)
I updated the readme and help - also with
works fine, but I cheated with stub. Edit: looks also fine without stub |
worked and looks good! amplicon recovered via V4.1 in omicron! I will merge, but once the ARTIC network puts the "offical" BED in their repository we might want to update again thx! |
fixes #175
I avoided a
.
in the folder's name, since it could have an effect, whensimpleName
is used.If you prefer something else, let me know!