Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARTIC V4.1 primer scheme for Omicron #175

Closed
hoelzer opened this issue Dec 1, 2021 · 9 comments · Fixed by #182
Closed

ARTIC V4.1 primer scheme for Omicron #175

hoelzer opened this issue Dec 1, 2021 · 9 comments · Fixed by #182
Assignees
Labels
enhancement New feature or request prio: high

Comments

@hoelzer
Copy link
Collaborator

hoelzer commented Dec 1, 2021

We might need to add support for V4.1 soon:

https://twitter.com/Scalene/status/1466070415986544640

https://community.artic.network/t/sars-cov-2-v4-1-update-for-omicron-variant/342

@hoelzer hoelzer added the enhancement New feature or request label Dec 1, 2021
@replikation
Copy link
Owner

we might want to implement also a "flexible" approach for a user to supply just a primer bed file?
otherwise, just copy V4 and add the primer bed to the dir :)
--primerV basically just specifies the primer dir to use which is located here: https://github.com/replikation/poreCov/tree/master/data/external_primer_schemes/nCoV-2019

therefore adding any dir and using the dir name in --primerV will work

@hoelzer
Copy link
Collaborator Author

hoelzer commented Dec 1, 2021

k great!

we might want to implement also a "flexible" approach for a user to supply just a primer bed file?
actually, this might be helpful for a few users as well, yes. Only the primer bed is needed, right? Assuming then the primer positions are based on the correct reference Wuhan FASTA, which is right now always the case basically

@hoelzer
Copy link
Collaborator Author

hoelzer commented Dec 15, 2021

We will test V4.1 soon, so would be good to get the primer BED in poreCov.

But yet can not find something here https://github.com/artic-network/artic-ncov2019/tree/master/primer_schemes/nCoV-2019

@hoelzer
Copy link
Collaborator Author

hoelzer commented Dec 15, 2021

@MarieLataretu
Copy link
Collaborator

Not quite sure, what this comment means, but the arctic guys are also on it:
artic-network/artic-ncov2019#86 (comment)

In the mean time, I have here a scheme file for V4.1: nCoV-2019.scheme.bed.txt
Not sorted, just concatenated - not sure if this is important.

@hoelzer
Copy link
Collaborator Author

hoelzer commented Dec 15, 2021

maybe that already does the trick, @MarieLataretu ! thx

Do you have time to add this as new primer kit to the pipeline? As @replikation wrote above, this should be relatively easy.

The best would be of course to use the "official" files once this issue artic-network/artic-ncov2019#86 (comment) is resolved. Maybe lets wait until tomorrow and see if the files are added then to the ARTIC primer repo :)

@MarieLataretu
Copy link
Collaborator

MarieLataretu commented Dec 15, 2021

Sure, I can do a PR!

As I understand poreCov, only the scheme file is used, right?

Edit: I think seqrs needs also the primer sequences

@replikation
Copy link
Owner

replikation commented Dec 15, 2021

just add a folder like this:
https://github.com/replikation/poreCov/tree/master/data/external_primer_schemes/nCoV-2019/VarSkipV1a

primer bed file and the fasta and fai file (can be copied). the dirname is the name for the --primerV flag.
seqrs is using the primer bed file
Make sure the filenames are the same (e.g. nCoV-2019.scheme.bed )

@hoelzer
Copy link
Collaborator Author

hoelzer commented Dec 15, 2021

Thx @MarieLataretu ! once we have the structure already in, we can also easily update to the official files from the ARTIC network once they ar available

MarieLataretu added a commit to MarieLataretu/poreCov that referenced this issue Dec 15, 2021
hoelzer added a commit that referenced this issue Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prio: high
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants