-
Notifications
You must be signed in to change notification settings - Fork 6
Add complimentary preflight for Security Tools detection #3015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer:
Airgap Installer (may take a few minutes before the airgap bundle is built):
Happy debugging! |
{{ "{{" }} .Detected {{ "}}" }} | ||
These types of tools have been known to interfere with Kubernetes operation in various ways. If you experience an installation problem, you may need to disable these tools temporarily as part of the troubleshooting process to identify if any system administrator exceptions may be required to maintain necessary internal Kubernetes operations. | ||
- systemPackages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the collector attempts to collect multiple system packages, would this analyzer exactly message look correct if the collector finds more than one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah youre right, it looks like it would render that message for each tool it detects, I'll make a commit that should render it as a single message
The following antivirus or network security tools were detected: | ||
{{ "{{" }} .Detected {{ "}}" }} | ||
These types of tools have been known to interfere with Kubernetes operation in various ways. If you experience an installation problem, you may need to disable these tools temporarily as part of the troubleshooting process to identify if any system administrator exceptions may be required to maintain necessary internal Kubernetes operations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajp-io should review the copy here.
outcomes: | ||
- warn: | ||
when: '{{ "{{" }} .IsInstalled {{ "}}" }}' | ||
message: Package {{ "{{" }} .Name {{ "}}" }} is installed. This tool can interfere with kubernetes operation. Ensure the tool is either disabled or configured to not interfere with kubernetes operation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajp-io should review the copy here.
What this PR does / why we need it:
Mirrors the recent support bundle analyzer into the host preflight to better and more clearly show interference from antivirus tools before installation issues occur. This emits warnings (not failures) and includes the list of detected tools plus guidance.
Which issue(s) this PR fixes:
https://app.shortcut.com/replicated/story/129800/add-complimentary-preflight-for-security-tools-detection
Does this PR require a test?
NONE
Does this PR require a release note?
Does this PR require documentation?
NONE