Update deployments.createPrediction to use wait #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evilstreak
force-pushed
the
replace-block-with-wait
branch
from
bddc975 to
5f8cfde
Compare
aron
requested changes
Oct 16, 2024
There was a problem hiding this comment.
Hmm, this is a bug rather than a feature. The final interface was always intended to be create. I think we just remove the block param entirely here and keep the implementation as you have it.
https://github.com/replicate/replicate-javascript/blob/main/index.d.ts#L210-L221
A first draft of this interface used `block`, but we ended up going with `wait` (as either a boolean or a number) for the predictions.createPrediction method. This commit brings the two implementations inline, removing the undocumented and unintended `block` parameter.
evilstreak
force-pushed
the
replace-block-with-wait
branch
from
5f8cfde to
fc9032f
Compare
|
@aron I've completely removed the old |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first draft of this interface used
block, but we ended up going withwait(as either a boolean or a number) for the predictions.createPrediction method. This commit brings the two implementations inline, and deprecates theblockparameter.Note: it would be nice to emit a warning about the deprecation if this method is called with the
blockparameter, but I'm not sure how to do that reliably across platforms. Advice welcome!