Bug fixes for the wait option in replicate.run
#315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the use of the `run.wait` parameter to only pass it to the `prediction.create` function if it's a number or integer. We now check to see if the status of the object returned has moved out of a starting state.
aron
commented
Oct 1, 2024
index.d.ts
Outdated
| @@ -162,7 +162,7 @@ declare module "replicate" { | |||
| signal?: AbortSignal; | |||
| }, | |||
| progress?: (prediction: Prediction) => void | |||
| ): Promise<object>; | |||
| ): Promise<unknown>; | |||
There was a problem hiding this comment.
This is probably a breaking change... maybe it's best left for another time.
mattt
approved these changes
Oct 1, 2024
aron
commented
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple of small bugs in the current implementation:
predictions.createwhen it was an object with an interval, resulting in the blocking mode being used accidentally.waitwhich would create a runtime error when thewaitfunction expects an object.This PR addresses these three issues by checking if the run should be blocking and passing the correct arguments in the correct places. We also assume that if the returned prediction is not in
startingstate then it is completed. This isn't ideal but works for the moment.Lastly, in the case where the blocking request times out the client will fall back to polling at the default interval.