-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wait
parameter to prediction creation methods
#308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the intention here to roll this out quietly via the block
param for testing?
Sort of. Because of how |
block
parameter to prediction creation methodswait
parameter to prediction creation methods
Co-authored-by: Aron Carroll <[email protected]>
Update type definitions to capture expectations of wait parameter in run
eb34008
to
0c0245d
Compare
stream?: boolean; | ||
webhook?: string; | ||
webhook_events_filter?: WebhookEventType[]; | ||
block?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I preferred the version we had that exposed wait
here. Where wait was one of:
wait?: { mode: "block", timeout?: number } | { mode: "poll", interval?: number }
This way we have only one param consistently, and it defaults to {mode: "block"}
.
No description provided.