fix: remove stable node.js API web crypto polyfill #243
+0
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aron
requested changes
May 2, 2024
There was a problem hiding this comment.
@himself65 I'm afraid this breaks support for Node 18, which we still need to support for the moment, or provide a clear migration path. Does removing the node: prefix work? I think in our case it doesn't really matter if we use the node protocol, require("crypto") will work.
|
@himself65 We just released v0.29.3, which incorporates the change @aron made in #250. Please give that a whirl and let us know if this still isn't working for you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #225
This won't fix #210 because react native doesn't have webcrypto API