Close the stream when receiving "done" event from the server #219
+85
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we hold the connection open indefinitely. This surfaced an issue in the `nock` patching of the ReadableStreams when using `fetch()` so instead we end up mocking fetch directly and providing the stream as a response.
aron
changed the title
mattt
reviewed
Mar 12, 2024
mattt
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced with #214 where we were not exiting correctly when getting the
"done"event from the server. This was picked up by the introduction of the CloudFlare integration tests added in #217 which uses the streaming API.Once the fix was added it turns out that the
nock()tests were incorrectly passing due to some internal weirdness when usingrespondWithand aReadableobject. I wasn't able to get this working without hitting a different error:It looks like nock is retaining some global state somewhere in it's implementation and streams are being retained across requests. No combination of resetting mocks seemed to fix it.
In the end I just mocked out the fetch function passed into the
createReadableStreamlibrary and returned aResponse. I think we should probably do this everywhere rather than usenock()as the Request/Response APIs provided by fetch are much better now than the old node http lib.