Fix stream() support for chunked event streams #211
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a subtle bug in the current
Stream
implementation where if the server emits lines in several chunks then we get "null" events in the async iterator.For example:
Will result in:
This PR fixes this, plus a few bugs in the
Stream
implementation:decode()
function in theStream
class processes full lines by retaining the last line of the current chunk and appending it to the start of the next chunk before splitting on newlines.validateWebhook
which returns aPromise<boolean>
but is typed to returnboolean
.