Sui integration #143
Draft
Sui integration #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR integrates support for the Sui blockchain into the wallet app by adding Sui key management, transaction signing, and UI components. Key changes include updating Package.swift dependencies and debug flags, integrating Sui account storage and presenter properties, and extending signing logic in the shared signer modules.
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Package.swift | Updated debug flag and dependency version for Yttrium |
| Example/WalletApp/PresentationLayer/Wallet/Welcome/* | Added Sui key input and updated account generation logic |
| Example/WalletApp/PresentationLayer/Wallet/Settings/* | Added Sui address and private key display for settings |
| Example/WalletApp/PresentationLayer/Wallet/SessionProposal/SessionProposalInteractor.swift | Integrated Sui chains into supported chains handling |
| Example/Shared/Signer/* | Added SuiSigner and updated Signer routing for Sui requests |
| Xcode project files | Updated project references to include new Sui-related files |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves # (issue)
How Has This Been Tested?
Due Dilligence