Skip to content

Conversation

ignaciosantise
Copy link
Collaborator

Summary

Added github actions to run maestro tests between dapp and wallet

@ignaciosantise ignaciosantise requested a review from jakubuid June 18, 2025 14:20
@Copilot Copilot AI review requested due to automatic review settings October 7, 2025 19:19
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Maestro end-to-end testing infrastructure to automate testing between dapp and wallet applications. The changes include improved test reliability through testID additions, updated package dependencies, and comprehensive GitHub Actions workflows for both iOS and Android platforms.

  • Added testID props to ActionButton component and ModalFooter for reliable test element identification
  • Updated package dependencies across multiple dapp projects to newer versions
  • Created comprehensive GitHub Actions workflows for building and testing both iOS and Android applications with Maestro

Reviewed Changes

Copilot reviewed 28 out of 36 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
wallets/rn_cli_wallet/src/components/ActionButton.tsx Added testID prop to ActionButton component for test automation
wallets/rn_cli_wallet/src/components/Modal/ModalFooter.tsx Added testID attributes to approve and reject buttons
wallets/rn_cli_wallet/src/screens/Scan/index.tsx Fixed null check comparison for device variable
dapps/W3MWagmi/scripts/misc_internal.ts Temporarily disabled linkMode with TODO comment
dapps/W3MWagmi/package.json Updated multiple package versions including appkit and walletconnect dependencies
dapps/W3MEthers5/package.json Updated appkit and walletconnect package versions
dapps/W3MEthers/package.json Updated appkit and walletconnect package versions
.maestro/web/*.yaml Enhanced test flows with testID-based element selection and improved timing
.maestro/native/*.yaml Enhanced test flows with testID-based element selection and platform-specific handling
.github/workflows/ci_e2e_tests_ios.yaml Created comprehensive iOS E2E testing workflow with app building and Maestro testing
.github/workflows/ci_e2e_tests_android.yaml Created comprehensive Android E2E testing workflow with emulator setup and testing
.github/workflows/release-*.yaml Updated action versions and refactored file setup into reusable actions
.github/actions/ci-setup*/action.yml Created reusable actions for iOS and Android file setup, updated cache versions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

</TouchableOpacity>

{showCamera && device ? (
{showCamera && device != null ? (
Copy link
Preview

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use strict equality comparison (!== null) instead of loose inequality (!= null) for better type safety and consistency with modern JavaScript practices.

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants